linux-kernel - Re: [PATCH 1/2] mm/page_reporting: Add checks for page_reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210011507.RLMy6Fvc-lkp@intel.com>
Date:   Sat, 1 Oct 2022 16:00:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shradha Gupta <shradhagupta@...ux.microsoft.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Shradha Gupta <shradhagupta@...ux.microsoft.com>,
        Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH 1/2] mm/page_reporting: Add checks for
 page_reporting_order param value

Hi Shradha,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master v6.0-rc7 next-20220930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shradha-Gupta/Configurable-order-free-page-reporting-in-hyper-v/20220929-182918
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arm-randconfig-r003-20220926
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/c3ac7f3e00c93db62e279104fae0b6df0c80d4af
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shradha-Gupta/Configurable-order-free-page-reporting-in-hyper-v/20220929-182918
        git checkout c3ac7f3e00c93db62e279104fae0b6df0c80d4af
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/page_reporting.c:17:5: warning: no previous prototype for function 'page_order_update_notify' [-Wmissing-prototypes]
   int page_order_update_notify(const char *val, const struct kernel_param *kp)
       ^
   mm/page_reporting.c:17:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int page_order_update_notify(const char *val, const struct kernel_param *kp)
   ^
   static 
   1 warning generated.


vim +/page_order_update_notify +17 mm/page_reporting.c

    16	
  > 17	int page_order_update_notify(const char *val, const struct kernel_param *kp)
    18	{
    19		/*
    20		 * If param is set beyond this limit, order is set to default
    21		 * pageblock_order value
    22		 */
    23		return  param_set_uint_minmax(val, kp, 0, MAX_ORDER-1);
    24	}
    25	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (148025 bytes)