[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq1sfk7j21y.fsf@ca-mkp.ca.oracle.com>
Date: Sat, 01 Oct 2022 06:01:32 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Rafael Mendonca <rafaelmendsr@...il.com>
Cc: James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Gaurav Srivastava <gaurav.srivastava@...adcom.com>,
Hannes Reinecke <hare@...e.de>,
Muneendra Kumar <muneendra.kumar@...adcom.com>,
James Smart <jsmart2021@...il.com>, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: Fix memory leak in lpfc_create_port()
> Commit 5e633302ace1 ("scsi: lpfc: vmid: Add support for VMID in mailbox
> command") introduced allocations for the VMID resources in
> lpfc_create_port() after the call to scsi_host_alloc(). Upon failure on the
> VMID allocations, the new code would branch to the 'out' label, which
> returns NULL without unwinding anything, thus skipping the call to
> scsi_host_put().
Broadcom: Please review, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists