linux-kernel - Re: [PATCH v9 8/9] mfd: Add Ampere's Altra SMpro MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210011846.C6bLNnSD-lkp@intel.com>
Date:   Sat, 1 Oct 2022 18:11:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Quan Nguyen <quan@...amperecomputing.com>, macro@...am.me.uk,
        Lee Jones <lee@...nel.org>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jonathan Corbet <corbet@....net>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thu Nguyen <thu@...amperecomputing.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Open Source Submission <patches@...erecomputing.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Phong Vo <phong@...amperecomputing.com>,
        thang@...amperecomputing.com
Subject: Re: [PATCH v9 8/9] mfd: Add Ampere's Altra SMpro MFD driver

Hi Quan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on groeck-staging/hwmon-next lee-mfd/for-mfd-next linus/master v6.0-rc7 next-20220930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220929-174756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 3aa12610b481f99b5e4e3f801ff7f9b7629e4ecf
config: hexagon-randconfig-r041-20221001
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b5237c2e863cc2719cae133dcc218bb1cc165514
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Quan-Nguyen/Add-Ampere-s-Altra-SMPro-MFD-and-its-child-drivers/20220929-174756
        git checkout b5237c2e863cc2719cae133dcc218bb1cc165514
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/hwmon/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/hwmon/smpro-hwmon.c:378:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   drivers/hwmon/smpro-hwmon.c:378:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break; 
   1 warning generated.


vim +378 drivers/hwmon/smpro-hwmon.c

afdad0428cacb9 Quan Nguyen 2022-09-29  359  
afdad0428cacb9 Quan Nguyen 2022-09-29  360  static umode_t smpro_is_visible(const void *data, enum hwmon_sensor_types type,
afdad0428cacb9 Quan Nguyen 2022-09-29  361  				u32 attr, int channel)
afdad0428cacb9 Quan Nguyen 2022-09-29  362  {
afdad0428cacb9 Quan Nguyen 2022-09-29  363  	const struct smpro_hwmon *hwmon = data;
afdad0428cacb9 Quan Nguyen 2022-09-29  364  	unsigned int value;
afdad0428cacb9 Quan Nguyen 2022-09-29  365  	int ret;
afdad0428cacb9 Quan Nguyen 2022-09-29  366  
afdad0428cacb9 Quan Nguyen 2022-09-29  367  	switch (type) {
afdad0428cacb9 Quan Nguyen 2022-09-29  368  	case hwmon_temp:
afdad0428cacb9 Quan Nguyen 2022-09-29  369  		switch (attr) {
afdad0428cacb9 Quan Nguyen 2022-09-29  370  		case hwmon_temp_input:
afdad0428cacb9 Quan Nguyen 2022-09-29  371  		case hwmon_temp_label:
afdad0428cacb9 Quan Nguyen 2022-09-29  372  		case hwmon_temp_crit:
afdad0428cacb9 Quan Nguyen 2022-09-29  373  			ret = regmap_read(hwmon->regmap, temperature[channel].reg, &value);
afdad0428cacb9 Quan Nguyen 2022-09-29  374  			if (ret || value == 0xFFFF)
afdad0428cacb9 Quan Nguyen 2022-09-29  375  				return 0;
afdad0428cacb9 Quan Nguyen 2022-09-29  376  		break;
afdad0428cacb9 Quan Nguyen 2022-09-29  377  		}
afdad0428cacb9 Quan Nguyen 2022-09-29 @378  	default:
afdad0428cacb9 Quan Nguyen 2022-09-29  379  		break;
afdad0428cacb9 Quan Nguyen 2022-09-29  380  	}
afdad0428cacb9 Quan Nguyen 2022-09-29  381  
afdad0428cacb9 Quan Nguyen 2022-09-29  382  	return 0444;
afdad0428cacb9 Quan Nguyen 2022-09-29  383  }
afdad0428cacb9 Quan Nguyen 2022-09-29  384  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (100918 bytes)