linux-kernel - Re: [PATCH drm-misc-next v2 7/9] drm/arm/malidp: crtc: protect device resources after removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2022 03:47:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Danilo Krummrich <dakr@...hat.com>, daniel@...ll.ch,
        airlied@...ux.ie, tzimmermann@...e.de, mripard@...nel.org,
        liviu.dudau@....com, brian.starkey@....com
Cc:     kbuild-all@...ts.01.org, Danilo Krummrich <dakr@...hat.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH drm-misc-next v2 7/9] drm/arm/malidp: crtc: protect
 device resources after removal

Hi Danilo,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 08fb97de03aa2205c6791301bd83a095abc1949c]

url:    https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-arm-malidp-use-drm-managed-resources/20221002-004256
base:   08fb97de03aa2205c6791301bd83a095abc1949c
config: s390-allyesconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/379208cbeb040ca0643b28ff14ca3f6ab99128a4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Danilo-Krummrich/drm-arm-malidp-use-drm-managed-resources/20221002-004256
        git checkout 379208cbeb040ca0643b28ff14ca3f6ab99128a4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/drm/arm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/arm/malidp_crtc.c: In function 'malidp_crtc_mode_valid':
>> drivers/gpu/drm/arm/malidp_crtc.c:31:30: warning: variable 'status' set but not used [-Wunused-but-set-variable]
      31 |         enum drm_mode_status status = MODE_OK;
         |                              ^~~~~~


vim +/status +31 drivers/gpu/drm/arm/malidp_crtc.c

    25	
    26	static enum drm_mode_status malidp_crtc_mode_valid(struct drm_crtc *crtc,
    27							   const struct drm_display_mode *mode)
    28	{
    29		struct malidp_drm *malidp = crtc_to_malidp_device(crtc);
    30		struct malidp_hw_device *hwdev = malidp->dev;
  > 31		enum drm_mode_status status = MODE_OK;
    32		int idx;
    33	
    34		/*
    35		 * check that the hardware can drive the required clock rate,
    36		 * but skip the check if the clock is meant to be disabled (req_rate = 0)
    37		 */
    38		long rate, req_rate = mode->crtc_clock * 1000;
    39	
    40		if (!drm_dev_enter(&malidp->base, &idx))
    41			return MODE_NOCLOCK;
    42	
    43		if (req_rate) {
    44			rate = clk_round_rate(hwdev->pxlclk, req_rate);
    45			if (rate != req_rate) {
    46				DRM_DEBUG_DRIVER("pxlclk doesn't support %ld Hz\n",
    47						 req_rate);
    48				status = MODE_NOCLOCK;
    49				goto out;
    50			}
    51		}
    52	
    53	out:
    54		drm_dev_exit(idx);
    55		return MODE_OK;
    56	}
    57	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (305627 bytes)