lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 1 Oct 2022 22:16:04 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, ChiaEn Wu <chiaen_wu@...htek.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] power: supply: mt6370: uses IIO interfaces, depends on
 IIO

Hi,

On Wed, Sep 28, 2022 at 11:29:40PM -0700, Randy Dunlap wrote:
> The mt6370-charger driver uses IIO interfaces and produces build
> errors when CONFIG_IIO is not set, so it should depend on IIO.
> 
> ERROR: modpost: "iio_read_channel_processed" [drivers/power/supply/mt6370-charger.ko] undefined!
> ERROR: modpost: "devm_iio_channel_get_all" [drivers/power/supply/mt6370-charger.ko] undefined!
> 
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: ChiaEn Wu <chiaen_wu@...htek.com>
> Cc: Sebastian Reichel <sebastian.reichel@...labora.com>
> Cc: linux-pm@...r.kernel.org
> ---
>  drivers/power/supply/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
>  	tristate "MediaTek MT6370 Charger Driver"
>  	depends on MFD_MT6370
>  	depends on REGULATOR
> +	depends on IIO
>  	select LINEAR_RANGES
>  	help
>  	  Say Y here to enable MT6370 Charger Part.

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ