[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221001202918.me7z2qzm7cmrkzsg@mercury.elektranox.org>
Date: Sat, 1 Oct 2022 22:29:18 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Rob Herring <robh+dt@...nel.org>
Cc: ChiaEn Wu <peterwu.pub@...il.com>, pavel@....cz,
krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
jic23@...nel.org, lars@...afoo.de, broonie@...nel.org,
mazziesaccount@...il.com, andriy.shevchenko@...ux.intel.com,
chiaen_wu@...htek.com, alice_chen@...htek.com,
cy_huang@...htek.com, linux-leds@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, linux-iio@...r.kernel.org,
szunichen@...il.com,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v11 1/8] dt-bindings: power: supply: Add MediaTek MT6370
Charger
Hi,
On Mon, Sep 26, 2022 at 09:52:06AM -0500, Rob Herring wrote:
> On Thu, Sep 15, 2022 at 4:49 AM ChiaEn Wu <peterwu.pub@...il.com> wrote:
> >
> > From: ChiaEn Wu <chiaen_wu@...htek.com>
> >
> > Add MediaTek MT6370 Charger binding documentation.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> > ---
> > v11
> > - Add more detailed description of irqs.
> > - Adujust the order of irqs
> > ---
> > .../power/supply/mediatek,mt6370-charger.yaml | 96 ++++++++++++++++++++++
> > 1 file changed, 96 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> > new file mode 100644
> > index 0000000..fd491c5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> > @@ -0,0 +1,96 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek MT6370 Battery Charger
> > +
> > +maintainers:
> > + - ChiaEn Wu <chiaen_wu@...htek.com>
> > +
> > +description: |
> > + This module is part of the MT6370 MFD device.
> > + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6370-charger
> > +
> > + interrupts:
> > + description: |
> > + Specify what irqs are needed to be handled by MT6370 Charger driver.
> > + We need to use the IRQ "MT6370_IRQ_OVPCTRL_UVP_D" to know when USB
> > + is plugged in, and then the driver will enable BC1.2 detection.
> > + After the hardware of MT6370 completes the BC1.2 detection,
> > + IRQ "MT6370_IRQ_ATTACH" will be triggered, and the driver will know
> > + the result of BC1.2 detection.
> > + When the IRQ "MT6370_IRQ_CHG_MIVR" is triggered, it means that the
> > + hardware enters the "Minimum Input Voltage Regulation loop" and
> > + a workaround needs to be applied at this time.
> > + In summary, "MT6370_IRQ_OVPCTRL_UVP_D", "MT6370_IRQ_ATTACH" and
> > + "MT6370_IRQ_CHG_MIVR" are required in this charger driver.
> > + items:
> > + - description: irq of "USB is plugged in"
> > + - description: irq of "BC1.2 is done"
> > + - description: irq of "Minimum Input Voltage Regulation loop is active"
> > +
> > + interrupt-names:
> > + items:
> > + - const: uvp_d_evt
> > + - const: attach_i
> > + - const: mivr
>
> Now warning in linux-next:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
> charger: interrupt-names:0: 'uvp_d_evt' was expected
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
> charger: interrupt-names:1: 'attach_i' was expected
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
Looks like the example in the MFD binding has the order of uvp_d_evt
and attach_i swapped. ChiaEn Wu, please send a fix.
-- Sebastian
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists