linux-kernel - Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2022 15:00:12 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Shravan.Chippa@...rochip.com
Cc:     paul.j.murphy@...el.com, daniele.alessandrelli@...el.com,
        mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Conor.Dooley@...rochip.com,
        Prakash.Battu@...rochip.com
Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode

On Sun, Oct 02, 2022 at 04:42:06AM +0000, Shravan.Chippa@...rochip.com wrote:
> > > > > > +830,13 @@ static int imx334_set_pad_format(struct v4l2_subdev
> > > > > > *sd,
> > > > > >
> > > > > >       mutex_lock(&imx334->mutex);
> > > > > >
> > > > > > -     mode = &supported_mode;
> > > > > > +     imx334->cur_code = imx334_get_format_code(imx334, fmt);
> > > > >
> > > > > This should be done only for the active format.
> > > > Are you expecting  if condition to check the current bus code with
> > > set_pad_fromat bus code?
> > >
> > > Only assign the cur_code field when setting the active format.
> > I have taken reference from imx219 driver cur_code will update if the requested
> > format bus code maches with available bus_codes list if not mached with
> > available bus_codes it will use defaults one only.
> > am I missing any thing here ?
> 
> R u expecting to change the current bus code when get the V4L2_SUBDEV_FORMAT_ACTIVE requested?
> I will try to modify in the next revision this case.

Yes, please.

-- 
Sakari Ailus