linux-kernel - Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2022 14:13:44 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Ibrahim Tilki <Ibrahim.Tilki@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <Nuno.Sa@...log.com>,
        <Nurettin.Bolucu@...log.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver

On Tue, 27 Sep 2022 17:18:49 +0300
Ibrahim Tilki <Ibrahim.Tilki@...log.com> wrote:

> Adding support for max11410 24-bit, 1.9ksps delta-sigma adc which
> has 3 differential reference and 10 differential channel inputs.
> Inputs and references can be buffered internally. Inputs can also
> be amplified with internal PGA.
> 
> Device has four digital filter modes: FIR50/60, FIR50, FIR60 and SINC4.
> FIR 50Hz and 60Hz rejections can be enabled/disabled separately.
> Digital filter selection affects sampling frequency range so driver
> has to consider the configured filter when configuring sampling frequency.
> 
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@...log.com>

Hi Ibrahim,

Other than the obvious (form the build bug report) missing
#include <asm/unaligned.h>

this looks good to me.  I may of course spot something on v7, but hopefully
we can get the binding issues resolved and get this queued up.

Thanks,

Jonathan