lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20221003202441.11773-1-rdunlap@infradead.org> Date: Mon, 3 Oct 2022 13:24:41 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: linux-kernel@...r.kernel.org Cc: Randy Dunlap <rdunlap@...radead.org>, Igor Zhbanov <izh1979@...il.com>, "David S. Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>, Andrew Morton <akpm@...ux-foundation.org>, stable@...r.kernel.org, Arnd Bergmann <arnd@...db.de> Subject: [PATCH v4] sparc64: NMI watchdog: fix return value of __setup handler __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from setup_nmi_watchdog(). Fixes: e5553a6d0442 ("sparc64: Implement NMI watchdog on capable cpus.") Signed-off-by: Randy Dunlap <rdunlap@...radead.org> Reported-by: Igor Zhbanov <izh1979@...il.com> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru Cc: "David S. Miller" <davem@...emloft.net> Cc: sparclinux@...r.kernel.org Cc: Sam Ravnborg <sam@...nborg.org> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: stable@...r.kernel.org Cc: Arnd Bergmann <arnd@...db.de> --- v2: change From" Igor to Reported-by: add more Cc's v3: use Igor's current email address v4: add Arnd to Cc: list arch/sparc/kernel/nmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/sparc/kernel/nmi.c +++ b/arch/sparc/kernel/nmi.c @@ -274,7 +274,7 @@ static int __init setup_nmi_watchdog(cha if (!strncmp(str, "panic", 5)) panic_on_timeout = 1; - return 0; + return 1; } __setup("nmi_watchdog=", setup_nmi_watchdog);
Powered by blists - more mailing lists