linux-kernel - Re: [PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73726dc3-f6d2-144e-680a-5ee9e2b2edc9@somainline.org>
Date:   Mon, 3 Oct 2022 23:12:34 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Dzmitry Sankouski <dsankouski@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: arm: add xiaomi,sagit board based on
 msm8998 chip


On 03/10/2022 20:55, Dzmitry Sankouski wrote:
> add xiaomi,sagit board (Xiaomi Mi 6) binding
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---

Binding changes should generally go before the actual patch, so that

there's no commit where there's an undocumented compatible.

Konrad

> Changes for v3:
> - remove unused 'sagit' compatible line
>
>   Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..294075bafb97 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -239,6 +239,7 @@ properties:
>                 - sony,xperia-lilac
>                 - sony,xperia-maple
>                 - sony,xperia-poplar
> +              - xiaomi,sagit
>             - const: qcom,msm8998
>   
>         - items: