linux-kernel - Re: [PATCH] ARM: sun9i: smp: fix out-of-bounds access error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7a7dc0a8-326d-7734-fc9c-3cc1121cb2e0@gmail.com>
Date:   Mon, 3 Oct 2022 15:10:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     William Zhang <william.zhang@...adcom.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>
Cc:     f.fainelli@...il.com, anand.gore@...adcom.com,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Mylène Josserand <mylene.josserand@...tlin.com>,
        Russell King <linux@...linux.org.uk>,
        Samuel Holland <samuel@...lland.org>,
        linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] ARM: sun9i: smp: fix out-of-bounds access error

On 9/28/22 18:29, William Zhang wrote:
> When running multi_v7_defconfig with CONFIG_UBSAN enabled, kernel
> reports UBSAN array-index-out-of-bounds error in sunxi_mc_smp_init
> function on non-sunxi platform.
> 
> Checking index to the sunxi_mc_smp_data array for out-of-bounds
> condition is needed to cover non-sunxi platform. Also fix the handling
> of return value from of_property_match_string function. Only negitive
> value is an error condition and should bail out from the function.
> 
> Fixes: 1631090e34f5 ("ARM: sun9i: smp: Add is_a83t field")
> 
> Signed-off-by: William Zhang <william.zhang@...adcom.com>

FWIW:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian