| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Oct 2022 07:35:35 +0800
From: kernel test robot <lkp@...el.com>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [thermal:thermal/linux-next 59/83]
drivers/thermal/armada_thermal.c:788:44: error: implicit declaration of
function 'of_thermal_get_trip_points'; did you mean 'of_thermal_get_ntrips'?
tree: git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git thermal/linux-next
head: 1ff4810b1723b5a65f1ac59b6615db09b1b9e2db
commit: 3d65789f1fceffd177123b4cf3c52c17475e667e [59/83] thermal/of: Remove unused functions
config: arc-allyesconfig
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/commit/?id=3d65789f1fceffd177123b4cf3c52c17475e667e
git remote add thermal git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
git fetch --no-tags thermal thermal/linux-next
git checkout 3d65789f1fceffd177123b4cf3c52c17475e667e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
Note: the thermal/thermal/linux-next HEAD 1ff4810b1723b5a65f1ac59b6615db09b1b9e2db builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
drivers/thermal/armada_thermal.c: In function 'armada_configure_overheat_int':
>> drivers/thermal/armada_thermal.c:788:44: error: implicit declaration of function 'of_thermal_get_trip_points'; did you mean 'of_thermal_get_ntrips'? [-Werror=implicit-function-declaration]
788 | const struct thermal_trip *trips = of_thermal_get_trip_points(tz);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| of_thermal_get_ntrips
drivers/thermal/armada_thermal.c:788:44: warning: initialization of 'const struct thermal_trip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
cc1: some warnings being treated as errors
--
drivers/thermal/hisi_thermal.c: In function 'hisi_thermal_register_sensor':
>> drivers/thermal/hisi_thermal.c:498:16: error: implicit declaration of function 'of_thermal_get_trip_points'; did you mean 'of_thermal_get_ntrips'? [-Werror=implicit-function-declaration]
498 | trip = of_thermal_get_trip_points(sensor->tzd);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| of_thermal_get_ntrips
drivers/thermal/hisi_thermal.c:498:14: warning: assignment to 'const struct thermal_trip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
498 | trip = of_thermal_get_trip_points(sensor->tzd);
| ^
cc1: some warnings being treated as errors
--
drivers/thermal/uniphier_thermal.c: In function 'uniphier_tm_probe':
>> drivers/thermal/uniphier_thermal.c:300:17: error: implicit declaration of function 'of_thermal_get_trip_points'; did you mean 'of_thermal_get_ntrips'? [-Werror=implicit-function-declaration]
300 | trips = of_thermal_get_trip_points(tdev->tz_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| of_thermal_get_ntrips
drivers/thermal/uniphier_thermal.c:300:15: warning: assignment to 'const struct thermal_trip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
300 | trips = of_thermal_get_trip_points(tdev->tz_dev);
| ^
cc1: some warnings being treated as errors
--
drivers/thermal/qcom/qcom-spmi-temp-alarm.c: In function 'qpnp_tm_set_trip_temp':
>> drivers/thermal/qcom/qcom-spmi-temp-alarm.c:272:23: error: implicit declaration of function 'of_thermal_get_trip_points'; did you mean 'of_thermal_get_ntrips'? [-Werror=implicit-function-declaration]
272 | trip_points = of_thermal_get_trip_points(chip->tz_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| of_thermal_get_ntrips
drivers/thermal/qcom/qcom-spmi-temp-alarm.c:272:21: warning: assignment to 'const struct thermal_trip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
272 | trip_points = of_thermal_get_trip_points(chip->tz_dev);
| ^
drivers/thermal/qcom/qcom-spmi-temp-alarm.c: In function 'qpnp_tm_get_critical_trip_temp':
drivers/thermal/qcom/qcom-spmi-temp-alarm.c:310:15: warning: assignment to 'const struct thermal_trip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
310 | trips = of_thermal_get_trip_points(chip->tz_dev);
| ^
cc1: some warnings being treated as errors
vim +788 drivers/thermal/armada_thermal.c
8d98761a6fc1ee Miquel Raynal 2018-07-16 774
879d7362d1d01e Miquel Raynal 2018-12-12 775 /*
879d7362d1d01e Miquel Raynal 2018-12-12 776 * The IP can manage to trigger interrupts on overheat situation from all the
879d7362d1d01e Miquel Raynal 2018-12-12 777 * sensors. However, the interrupt source changes along with the last selected
879d7362d1d01e Miquel Raynal 2018-12-12 778 * source (ie. the last read sensor), which is an inconsistent behavior. Avoid
879d7362d1d01e Miquel Raynal 2018-12-12 779 * possible glitches by always selecting back only one channel (arbitrarily: the
879d7362d1d01e Miquel Raynal 2018-12-12 780 * first in the DT which has a critical trip point). We also disable sensor
879d7362d1d01e Miquel Raynal 2018-12-12 781 * switch during overheat situations.
879d7362d1d01e Miquel Raynal 2018-12-12 782 */
879d7362d1d01e Miquel Raynal 2018-12-12 783 static int armada_configure_overheat_int(struct armada_thermal_priv *priv,
879d7362d1d01e Miquel Raynal 2018-12-12 784 struct thermal_zone_device *tz,
879d7362d1d01e Miquel Raynal 2018-12-12 785 int sensor_id)
879d7362d1d01e Miquel Raynal 2018-12-12 786 {
879d7362d1d01e Miquel Raynal 2018-12-12 787 /* Retrieve the critical trip point to enable the overheat interrupt */
879d7362d1d01e Miquel Raynal 2018-12-12 @788 const struct thermal_trip *trips = of_thermal_get_trip_points(tz);
879d7362d1d01e Miquel Raynal 2018-12-12 789 int ret;
879d7362d1d01e Miquel Raynal 2018-12-12 790 int i;
879d7362d1d01e Miquel Raynal 2018-12-12 791
879d7362d1d01e Miquel Raynal 2018-12-12 792 if (!trips)
879d7362d1d01e Miquel Raynal 2018-12-12 793 return -EINVAL;
879d7362d1d01e Miquel Raynal 2018-12-12 794
879d7362d1d01e Miquel Raynal 2018-12-12 795 for (i = 0; i < of_thermal_get_ntrips(tz); i++)
879d7362d1d01e Miquel Raynal 2018-12-12 796 if (trips[i].type == THERMAL_TRIP_CRITICAL)
879d7362d1d01e Miquel Raynal 2018-12-12 797 break;
879d7362d1d01e Miquel Raynal 2018-12-12 798
879d7362d1d01e Miquel Raynal 2018-12-12 799 if (i == of_thermal_get_ntrips(tz))
879d7362d1d01e Miquel Raynal 2018-12-12 800 return -EINVAL;
879d7362d1d01e Miquel Raynal 2018-12-12 801
879d7362d1d01e Miquel Raynal 2018-12-12 802 ret = armada_select_channel(priv, sensor_id);
879d7362d1d01e Miquel Raynal 2018-12-12 803 if (ret)
879d7362d1d01e Miquel Raynal 2018-12-12 804 return ret;
879d7362d1d01e Miquel Raynal 2018-12-12 805
879d7362d1d01e Miquel Raynal 2018-12-12 806 armada_set_overheat_thresholds(priv,
879d7362d1d01e Miquel Raynal 2018-12-12 807 trips[i].temperature,
879d7362d1d01e Miquel Raynal 2018-12-12 808 trips[i].hysteresis);
879d7362d1d01e Miquel Raynal 2018-12-12 809 priv->overheat_sensor = tz;
879d7362d1d01e Miquel Raynal 2018-12-12 810 priv->interrupt_source = sensor_id;
879d7362d1d01e Miquel Raynal 2018-12-12 811
879d7362d1d01e Miquel Raynal 2018-12-12 812 armada_enable_overheat_interrupt(priv);
879d7362d1d01e Miquel Raynal 2018-12-12 813
879d7362d1d01e Miquel Raynal 2018-12-12 814 return 0;
879d7362d1d01e Miquel Raynal 2018-12-12 815 }
879d7362d1d01e Miquel Raynal 2018-12-12 816
:::::: The code at line 788 was first introduced by commit
:::::: 879d7362d1d01efd476a143c09048f5945936c32 thermal: armada: add overheat interrupt support
:::::: TO: Miquel Raynal <miquel.raynal@...tlin.com>
:::::: CC: Eduardo Valentin <edubezval@...il.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (313765 bytes)
Powered by blists - more mailing lists