linux-kernel - Re: [PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89533acf-b741-f587-d2d4-0f5bc534e3ee@linaro.org>
Date:   Mon, 3 Oct 2022 09:56:34 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kavyasree.Kotagiri@...rochip.com, lee@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     robh+dt@...nel.org, Nicolas.Ferre@...rochip.com,
        alexandre.belloni@...tlin.com, Claudiu.Beznea@...rochip.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        Sergiu.Moga@...rochip.com, robh@...nel.org
Subject: Re: [PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to
 json-schema

On 19/09/2022 07:27, Kavyasree.Kotagiri@...rochip.com wrote:
>> Convert the Atmel flexcom device tree bindings to json schema.
>>
>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> ---
>> v8 -> v9:
>>  - Use full schema path for i2c bindings.
>>
>> Changing reference to SPI yaml bindings is covered in below patch series:
>> https://lore.kernel.org/linux-arm-kernel/20220913142205.162399-6-
>> sergiu.moga@...rochip.com/
>> https://lore.kernel.org/linux-arm-kernel/dad37ca0-a44b-59ec-0be9-
>> fb121de12244@...aro.org/
>>
>> v7 -> v8:
>>  - Added back patternProperties for child nodes.
>>
>> v6 -> v7:
>>  - Change filename to atmel,sama5d2-flexcom.yaml
>>  - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>>
>> v5 -> v6:
>>  - Removed spi node from example as suggested by Rob and
>>    also pattern properties(spi dt-bindings conversion to yaml patch is under
>> review).
>>    Once that is accepted, I will add back spi example through new patch.
>>
>> v4 -> v5:
>>  - Fixed indentations.
>>
>> v3 -> v4:
>>  - Corrected format of enum used for compatible string.
>>
>> v2 -> v3:
>>  - used enum for compatible string.
>>  - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
>>  - fixed dtschema errors.
>>
>> v1 -> v2:
>>  - Fix title.
>>
>>  .../bindings/mfd/atmel,sama5d2-flexcom.yaml   | 92 +++++++++++++++++++
>>  .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 -------------
>>  2 files changed, 92 insertions(+), 63 deletions(-)
>>  create mode 100644
>> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
>> flexcom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>> new file mode 100644
>> index 000000000000..f28522cd987a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>> @@ -0,0 +1,92 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel Flexcom (Flexible Serial Communication Unit)
>> +
>> +maintainers:
>> +  - Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
>> +
>> +description:
>> +  The Atmel Flexcom is just a wrapper which embeds a SPI controller,
>> +  an I2C controller and an USART. Only one function can be used at a
>> +  time and is chosen at boot time according to the device tree.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - atmel,sama5d2-flexcom
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  "#address-cells":
>> +    const: 1
>> +
>> +  "#size-cells":
>> +    const: 1
>> +
>> +  ranges:
>> +    description:
>> +      One range for the full I/O register region. (including USART,
>> +      TWI and SPI registers).
>> +    items:
>> +      maxItems: 3
>> +
>> +  atmel,flexcom-mode:
>> +    description: |
>> +      Specifies the flexcom mode as follows:
>> +      1: USART
>> +      2: SPI
>> +      3: I2C.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [1, 2, 3]
>> +
>> +patternProperties:
>> +  "^serial@[0-9a-f]+$":
>> +    type: object
>> +    description:
>> +      Child node describing USART. See atmel-usart.txt for details
>> +      of USART bindings.
>> +
>> +  "^spi@[0-9a-f]+$":
>> +    type: object
>> +    description:
>> +      Child node describing SPI. See ../spi/spi_atmel.txt for details
>> +      of SPI bindings.
>> +
>> +  "^i2c@[0-9a-f]+$":
>> +    $ref: /schemas/i2c/atmel,at91sam-i2c.yaml
> 
> 
> Hi Krzysztof,
> 
> I added full schema path for i2c bindings in v9. Please let me know your comments.
> 

You sent the patch on 16th, pinged on 19th. Wait around two weeks before
pinging.

You got here Rob's review, what is missing? Why do you ping us?

Best regards,
Krzysztof