[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <166480909049.2249063.7109234696871106188.robh@kernel.org>
Date: Mon, 3 Oct 2022 09:58:18 -0500
From: Rob Herring <robh@...nel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: houlong.wei@...iatek.com, linux-kernel@...r.kernel.org,
jassisinghbrar@...il.com, linux-arm-kernel@...ts.infradead.org,
matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH v4] dt-bindings: mailbox: Convert mtk-gce to DT schema
On Wed, 21 Sep 2022 11:00:06 +0200, AngeloGioacchino Del Regno wrote:
> Convert the mtk-gce mailbox binding to DT schema format.
>
> During the conversion, the examples for client device/mutex nodes
> were removed, as these are found in their respective bindings:
> arm/mediatek/mediatek,mmsys.yaml for "mediatek,mt8173-mmsys"
> soc/mediatek/mediatek,mutex.yaml for "mediatek,mt8173-disp-mutex"
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>
> Changes in v4:
> - Removed deprecated examples comment
> - Fixed address for gce example
> - clock-names variation is now in allOf block
> - Added soc bus node with two address/size cells, as to
> provide a more practical example for the gce node
>
> Changes in v3:
> - Removed '|' from description
> - Removed mbox client examples
> - Squashed patch dt-bindings: arm: mediatek:
> mmsys: Reference to mediatek,gce-mailbox.yaml
>
> Changes in v2:
> - Changed mtk-gce.txt references to new yaml file
>
>
> A previous attempt for this was made at [1], but it was changing
> the way of getting clocks (by name for all).
> Keeping clock-names not required for the multi-gce case makes this
> binding simpler, hence I chose to abandon the change at [1] and go
> for this one instead.
>
> Any Reviewed-by or Acked-by tag was dropped, as this conversion was
> completely redone from scratch and differs from [1] for the
> aforementioned reasons.
>
> [1]: https://lore.kernel.org/all/20220524151512.247435-1-angelogioacchino.delregno@collabora.com/
>
> .../bindings/arm/mediatek/mediatek,mmsys.yaml | 3 +-
> .../mailbox/mediatek,gce-mailbox.yaml | 85 +++++++++++++++++++
> .../devicetree/bindings/mailbox/mtk-gce.txt | 82 ------------------
> 3 files changed, 87 insertions(+), 83 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> delete mode 100644 Documentation/devicetree/bindings/mailbox/mtk-gce.txt
>
Applied, thanks!
Powered by blists - more mailing lists