lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABnWg9sJFBAXi1bu_yHDppFOmg=H=G7QTn9Bzqkr-t7qm5vUFw@mail.gmail.com> Date: Mon, 3 Oct 2022 17:29:36 +0200 From: Guillaume Ranquet <granquet@...libre.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Kishon Vijay Abraham I <kishon@...com>, Matthias Brugger <matthias.bgg@...il.com>, Vinod Koul <vkoul@...nel.org>, Stephen Boyd <sboyd@...nel.org>, David Airlie <airlied@...ux.ie>, Rob Herring <robh+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Daniel Vetter <daniel@...ll.ch>, Chunfeng Yun <chunfeng.yun@...iatek.com>, CK Hu <ck.hu@...iatek.com>, Jitao shi <jitao.shi@...iatek.com>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Michael Turquette <mturquette@...libre.com> Cc: linux-mediatek@...ts.infradead.org, dri-devel@...ts.freedesktop.org, Pablo Sun <pablo.sun@...iatek.com>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Mattijs Korpershoek <mkorpershoek@...libre.com>, linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org, devicetree@...r.kernel.org Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote: >On 27/09/2022 15:04, Guillaume Ranquet wrote: >> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >> <krzysztof.kozlowski@...aro.org> wrote: >>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>> Add dpi support to enable the HDMI path. >>>> >>>> Signed-off-by: Guillaume Ranquet <granquet@...libre.com> >>>> >>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> index 72049a530ae1..27f029ca760b 100644 >>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>> .data = (void *)MTK_DPI }, >>>> { .compatible = "mediatek,mt8192-dpi", >>>> .data = (void *)MTK_DPI }, >>>> + { .compatible = "mediatek,mt8195-dpi", >>>> + .data = (void *)MTK_DPI }, >>> >>> It's compatible with the others. You don't need more compatibles. >> >> Hi Krzysztof, >> >> It's a bit confusing, because this compatible is used in both >> mtk_drm_drv.c and in mtk_dpi.c >> >> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >> it's pretty different >> regarding the mtk_dpi module. > >Sure, but this does not explain why do you need these entries here in >mtk_drm_drv. > >Best regards, >Krzysztof > Hi Krzysztof, Sorry for the late answer. The mtk_drm_drv is the component master of the full mediatek drm stack. it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. That mtk_ddp_comp_dt_ids array is iterated over to find all of the components from the device tree. Hope this clarifies things? Thx, Guillaume.
Powered by blists - more mailing lists