linux-kernel - [PATCH] Input: misc - atmel_captouch does not depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221003172953.30354439@endymion.delvare>
Date:   Mon, 3 Oct 2022 17:29:53 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Daniel Hung-yu Wu <hywu@...gle.com>, linux-input@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] Input: misc - atmel_captouch does not depend on OF

The atmel_captouch driver does not actually depend on OF, it includes
a non-OF device ID which could be used to instantiate the device, and
the driver code is already prepared to be built with or without OF. So
drop the unneeded dependency.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Daniel Hung-yu Wu <hywu@...gle.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
---
The problem I'm trying to solve here is that "depends on OF ||
COMPILE_TEST" does not make sense since OF can now be enabled on all
architectures. One way to fix this is by removing the dependency
altogether (this patch).

If the driver is known to be needed only on OF-enabled systems then we
could leave the dependency on OF and only drop COMPILE_TEST (and
simplify the driver code accordingly). I have an alternative patch
doing that already. Tell me what you prefer, I'm fine either way.

 drivers/input/misc/Kconfig |    1 -
 1 file changed, 1 deletion(-)

--- linux-5.19.orig/drivers/input/misc/Kconfig
+++ linux-5.19/drivers/input/misc/Kconfig
@@ -107,7 +107,6 @@ config INPUT_ATC260X_ONKEY

 config INPUT_ATMEL_CAPTOUCH
 	tristate "Atmel Capacitive Touch Button Driver"
-	depends on OF || COMPILE_TEST
 	depends on I2C
 	help
 	  Say Y here if an Atmel Capacitive Touch Button device which

-- 
Jean Delvare
SUSE L3 Support