linux-kernel - Re: [PATCHSET 0/7] perf stat: Small random cleanups (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzyAA/RaIGoxCbGI@kernel.org>
Date:   Tue, 4 Oct 2022 15:48:35 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        James Clark <james.clark@....com>
Subject: Re: [PATCHSET 0/7] perf stat: Small random cleanups (v2)

Em Fri, Sep 30, 2022 at 01:21:03PM -0700, Namhyung Kim escreveu:
> Hello,
> 
> I'm working on perf stat and I found some items to clean up.  This time
> I removed runtime stats for per-thread aggregation mode which we can simply
> use thread map index to compare the shadow stat values in the rt_stat.
> 
> Changes from v1)
>  * renaming missing parts in headers  (James)
>  * add a comment for map_idx  (Ian)
>  * add Reviewed-by from James
> 
> The code is available at 'perf/stat-cleanup-v2' branch in
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Applied locally, testing.

- Arnaldo
 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (7):
>   perf stat: Convert perf_stat_evsel.res_stats array
>   perf stat: Don't call perf_stat_evsel_id_init() repeatedly
>   perf stat: Rename saved_value->cpu_map_idx
>   perf stat: Use thread map index for shadow stat
>   perf stat: Kill unused per-thread runtime stats
>   perf stat: Don't compare runtime stat for shadow stats
>   perf stat: Rename to aggr_cpu_id.thread_idx
> 
>  tools/perf/builtin-stat.c      |  54 ------
>  tools/perf/tests/topology.c    |  10 +-
>  tools/perf/util/cpumap.c       |   8 +-
>  tools/perf/util/cpumap.h       |   2 +-
>  tools/perf/util/stat-display.c |  32 ++--
>  tools/perf/util/stat-shadow.c  | 320 ++++++++++++++++-----------------
>  tools/perf/util/stat.c         |  20 +--
>  tools/perf/util/stat.h         |  10 +-
>  8 files changed, 189 insertions(+), 267 deletions(-)
> 
> 
> base-commit: 62e64c9d2fd12839c02f1b3e8b873e7cb34e8720
> -- 
> 2.38.0.rc1.362.ged0d419d3c-goog

-- 

- Arnaldo