linux-kernel - Re: [PATCH] staging: rtl8723bs: Remove redundant initialization of variable efuseValue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b82e784d-f4c5-10df-2bcb-ee69b0f4a317@gmail.com>
Date:   Tue, 4 Oct 2022 23:12:15 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Saurav Girepunje <saurav.girepunje@...il.com>,
        linux-staging@...ts.linux.dev
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Remove redundant initialization of
 variable efuseValue

On 10/4/22 17:35, Colin Ian King wrote:
> The variable efuseValue is being initialized with a value that is never
> read. The variable is being re-assigned later on. The initialization is
> redundant and can be removed.
> 
> Cleans up warning:
> drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable
> 'efuseValue' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 06e727ce9cc2..eb848f9bbf2c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -282,7 +282,7 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT
>   {
>   	u8 tmpidx = 0;
>   	u8 bResult = false;
> -	u32 efuseValue = 0;
> +	u32 efuseValue;
>   
>   	if (bPseudoTest)
>   		return Efuse_Write1ByteToFakeContent(addr, data);


I propose to remove all lines with efuseValue as it is dead code.

Make a v2 of this patch with version history below the ---

Thanks for your support.

Bye Philipp