linux-kernel - Re: [PATCH] media: atomisp: Fix spelling mistake "modee" -> "mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73a3969a-d821-f3ee-78ce-df2fedefecdb@gmail.com>
Date:   Tue, 4 Oct 2022 23:25:56 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: atomisp: Fix spelling mistake "modee" -> "mode"

On 10/4/22 18:13, Colin Ian King wrote:
> There is a spelling mistake in a literal string. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   .../media/atomisp/pci/css_2401_system/host/pixelgen_private.h   | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h b/drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h
> index 1c7938d8ccb5..8f79424bedb2 100644
> --- a/drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h
> +++ b/drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h
> @@ -161,7 +161,7 @@ STORAGE_CLASS_PIXELGEN_C void pixelgen_ctrl_dump_state(
>   		     state->syng_stat_fcnt);
>   	ia_css_print("Pixel Generator ID %d syng stat done  0x%x\n", ID,
>   		     state->syng_stat_done);
> -	ia_css_print("Pixel Generator ID %d tpg modee  0x%x\n", ID, state->tpg_mode);
> +	ia_css_print("Pixel Generator ID %d tpg mode  0x%x\n", ID, state->tpg_mode);
>   	ia_css_print("Pixel Generator ID %d tpg hcnt mask  0x%x\n", ID,
>   		     state->tpg_hcnt_mask);
>   	ia_css_print("Pixel Generator ID %d tpg hcnt mask  0x%x\n", ID,


This is typically to pedantic for a patch.

You can fix same type of issues at one time. Do not make your patch to long.

Use checkpatch.

Bye Philipp


./scripts/checkpatch.pl --file 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h
CHECK: Lines should not end with a '('
#32: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:32:
+STORAGE_CLASS_PIXELGEN_C hrt_data pixelgen_ctrl_reg_load(

WARNING: please, no spaces at the start of a line
#33: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:33:
+    const pixelgen_ID_t ID,$

WARNING: please, no spaces at the start of a line
#34: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:34:
+    const hrt_address reg)$

CHECK: Lines should not end with a '('
#38: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:38:
+	return ia_css_device_load_uint32(PIXELGEN_CTRL_BASE[ID] + reg * sizeof(

CHECK: Lines should not end with a '('
#46: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:46:
+STORAGE_CLASS_PIXELGEN_C void pixelgen_ctrl_reg_store(

WARNING: please, no spaces at the start of a line
#47: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:47:
+    const pixelgen_ID_t ID,$

WARNING: please, no spaces at the start of a line
#48: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:48:
+    const hrt_address reg,$

WARNING: please, no spaces at the start of a line
#49: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:49:
+    const hrt_data value)$

CHECK: Lines should not end with a '('
#69: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:69:
+STORAGE_CLASS_PIXELGEN_C void pixelgen_ctrl_get_state(

WARNING: please, no spaces at the start of a line
#70: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:70:
+    const pixelgen_ID_t ID,$

WARNING: please, no spaces at the start of a line
#71: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:71:
+    pixelgen_ctrl_state_t *state)$

CHECK: Lines should not end with a '('
#133: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:133:
+STORAGE_CLASS_PIXELGEN_C void pixelgen_ctrl_dump_state(

WARNING: please, no spaces at the start of a line
#134: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:134:
+    const pixelgen_ID_t ID,$

WARNING: please, no spaces at the start of a line
#135: FILE: 
drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h:135:
+    pixelgen_ctrl_state_t *state)$

total: 0 errors, 9 warnings, 5 checks, 184 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
       mechanically convert to the typical style using --fix or 
--fix-inplace.

drivers/staging/media/atomisp/pci/css_2401_system/host/pixelgen_private.h has 
style problems, please review.

NOTE: If any of the errors are false positives, please report
       them to the maintainer, see CHECKPATCH in MAINTAINERS.
kernel@...rix-ESPRIMO-P710:~/Documents/git/kernels/staging$