[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YzyvPq/VYiuvz6LS@kernel.org>
Date: Wed, 5 Oct 2022 01:10:06 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] tpm: st33zp24: drop support for platform data
On Fri, Sep 30, 2022 at 10:51:40PM -0700, Dmitry Torokhov wrote:
> Drop support for platform data from the driver because there are no
> users of st33zp24_platform_data structure in the mainline kernel.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> - .name = TPM_ST33_SPI,
> + .name = "st33zp24-spi",
> .pm = &st33zp24_spi_ops,
> .of_match_table = of_match_ptr(of_st33zp24_spi_match),
> .acpi_match_table = ACPI_PTR(st33zp24_spi_acpi_match),
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.h b/drivers/char/tpm/st33zp24/st33zp24.h
> index b387a476c555..6a26dbc3206b 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.h
> +++ b/drivers/char/tpm/st33zp24/st33zp24.h
> @@ -7,6 +7,9 @@
> #ifndef __LOCAL_ST33ZP24_H__
> #define __LOCAL_ST33ZP24_H__
>
> +#define TPM_ST33_I2C "st33zp24-i2c"
> +#define TPM_ST33_SPI "st33zp24-spi"
> +
> #define TPM_WRITE_DIRECTION 0x80
> #define ST33ZP24_BUFSIZE 2048
Sorry I missed this. Why don't you use TPM_ST33_SPI constant above
since you are anyway re-defining it?
BR, Jarkko
Powered by blists - more mailing lists