linux-kernel - Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yzyvya4wdfovw2eh@kernel.org>
Date:   Wed, 5 Oct 2022 01:12:25 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Thomas Tai <thomas.tai@...cle.com>
Cc:     "tony.luck@...el.com" <tony.luck@...el.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "reinette.chatre@...el.co" <reinette.chatre@...el.co>,
        "naoya.horiguchi@....com" <naoya.horiguchi@....com>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
 memory

On Sun, Oct 02, 2022 at 02:51:22PM +0000, Thomas Tai wrote:
> 
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@...nel.org>
> > Sent: September 30, 2022 5:51 PM
> > To: Thomas Tai <thomas.tai@...cle.com>
> > Cc: tony.luck@...el.com; dave.hansen@...ux.intel.com;
> > reinette.chatre@...el.co; naoya.horiguchi@....com; linmiaohe@...wei.com;
> > akpm@...ux-foundation.org; linux-mm@...ck.org; linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
> > memory
> > 
> > On Wed, Sep 28, 2022 at 11:38:32AM -0400, Thomas Tai wrote:
> > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > > address validation), add a similar code in hwpoison_inject function to
> > > check if the address is located in SGX Memory. The error will then be
> > > handled by the arch_memory_failure function in the SGX driver.
> > >
> > > Signed-off-by: Thomas Tai <thomas.tai@...cle.com>
> > > ---
> > >  Documentation/mm/hwpoison.rst | 44
> > +++++++++++++++++++++++++++++++++++
> > >  mm/hwpoison-inject.c          |  4 ++++
> > >  2 files changed, 48 insertions(+)
> > 
> > Hmm.. no change log.
> > 
> > What was the change in-between v1 and v2?
> 
> Hi Jarkko,
> I put the change log in [PATCH V2 0/1]. Following is the details, hope you find it useful.
> 
> Changes since v1:
> - Add a comment in hwpoison_inject as suggested by Miaohe
> - v1: Reviewed-by: Tony Luck <tony.luck@...el.com>
> - v1: Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
> 
> Thanks,
> Thomas

Also,


Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko