linux-kernel - Re: [PATCH v2 1/4] crypto: aspeed: Add ACRY RSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210041350.4dRhGF7P-lkp@intel.com>
Date:   Tue, 4 Oct 2022 13:48:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Neal Liu <neal_liu@...eedtech.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "Chia-Wei Wang --cc=linux-kernel @ vger . kernel . org" 
        <chiawei_wang@...eedtech.com>
Cc:     kbuild-all@...ts.01.org, linux-crypto@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] crypto: aspeed: Add ACRY RSA driver

Hi Neal,

I love your patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on next-20220930]
[cannot apply to herbert-crypto-2.6/master robh/for-next linus/master v6.0]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Neal-Liu/Add-Aspeed-ACRY-driver-for-hardware-acceleration/20221004-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b074e55ba308dfda90527144dfa77bea9b9a9321
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Neal-Liu/Add-Aspeed-ACRY-driver-for-hardware-acceleration/20221004-113050
        git checkout b074e55ba308dfda90527144dfa77bea9b9a9321
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/crypto/aspeed/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/platform_device.h:13,
                    from drivers/crypto/aspeed/aspeed-acry.c:12:
   drivers/crypto/aspeed/aspeed-acry.c: In function 'aspeed_acry_rsa_ctx_copy':
>> drivers/crypto/aspeed/aspeed-acry.c:27:28: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
      27 |         dev_info((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
         |                            ^~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
     150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                          ^~~~~~~
   drivers/crypto/aspeed/aspeed-acry.c:27:9: note: in expansion of macro 'dev_info'
      27 |         dev_info((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
         |         ^~~~~~~~
   drivers/crypto/aspeed/aspeed-acry.c:269:9: note: in expansion of macro 'ACRY_DBG'
     269 |         ACRY_DBG(acry_dev, "nbytes:0x%x, mode:%d\n", nbytes, mode);
         |         ^~~~~~~~


vim +27 drivers/crypto/aspeed/aspeed-acry.c

    24	
    25	#ifdef CONFIG_CRYPTO_DEV_ASPEED_DEBUG
    26	#define ACRY_DBG(d, fmt, ...)	\
  > 27		dev_info((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
    28	#else
    29	#define ACRY_DBG(d, fmt, ...)	\
    30		dev_dbg((d)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
    31	#endif
    32	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (311622 bytes)