lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1719c2ee-cf05-0885-38a8-7d1176020731@suse.de> Date: Tue, 4 Oct 2022 07:50:58 +0200 From: Hannes Reinecke <hare@...e.de> To: John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com, martin.petersen@...cle.com, jinpu.wang@...ud.ionos.com, damien.lemoal@....com Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, linuxarm@...wei.com, ipylypiv@...gle.com, changyuanl@...gle.com, hch@....de, yanaijie@...wei.com Subject: Re: [PATCH v2 3/6] scsi: pm8001: Remove pm8001_tag_init() On 9/30/22 10:56, John Garry wrote: > From: Igor Pylypiv <ipylypiv@...gle.com> > > In commit 5a141315ed7c ("scsi: pm80xx: Increase the number of outstanding > I/O supported to 1024") the pm8001_ha->tags allocation was moved into > pm8001_init_ccb_tag(). This changed the execution order of allocation. > pm8001_tag_init() used to be called after the pm8001_ha->tags allocation > and now it is called before the allocation. > > Before: > > pm8001_pci_probe() > `--> pm8001_pci_alloc() > `--> pm8001_alloc() > `--> pm8001_ha->tags = kzalloc(...) > `--> pm8001_tag_init(pm8001_ha); // OK: tags are allocated > > After: > > pm8001_pci_probe() > `--> pm8001_pci_alloc() > | `--> pm8001_alloc() > | `--> pm8001_tag_init(pm8001_ha); // NOK: tags are not allocated > | > `--> pm8001_init_ccb_tag() > `--> pm8001_ha->tags = kzalloc(...) // today it is bitmap_zalloc() > > Since pm8001_ha->tags_num is zero when pm8001_tag_init() is called it does > nothing. Tags memory is allocated with bitmap_zalloc() so there is no need > to manually clear each bit with pm8001_tag_free(). > > Reviewed-by: Changyuan Lyu <changyuanl@...gle.com> > Signed-off-by: Igor Pylypiv <ipylypiv@...gle.com> > Signed-off-by: John Garry <john.garry@...wei.com> > Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com> > --- > drivers/scsi/pm8001/pm8001_init.c | 2 -- > drivers/scsi/pm8001/pm8001_sas.c | 7 ------- > drivers/scsi/pm8001/pm8001_sas.h | 1 - > 3 files changed, 10 deletions(-) > Reviewed-by: Hannes Reinecke <hare@...e.de> Cheerx, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@...e.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Powered by blists - more mailing lists