linux-kernel - Re: [PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S: Supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30776fe75061951777da8fa6618ae89bea7a8ce4.camel@perches.com>
Date:   Tue, 04 Oct 2022 01:02:04 -0700
From:   Joe Perches <joe@...ches.com>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, corbet@....net,
        linux@...mhuis.info, konstantin@...uxfoundation.org,
        krzysztof.kozlowski@...aro.org, linux-doc@...r.kernel.org,
        akiyks@...il.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v4 1/2] get_maintainer: Print maintainer for S:
 Supported

On Mon, 2022-10-03 at 17:24 +0100, Bryan O'Donoghue wrote:
> Throughout the documentation we make reference to maintainers as the people
> who ought to be mailed when sending patches.
> 
> Right now get_maintainer.pl returns "supporter" for maintained files which
> are denoted "S: Supported".

As it should.

I think this patch is misguided and do not agree with the concept.

Either do away with the concept of S: Supported or use it.

As is, it merely hides the actual content of the MAINTAINERS file.

A reader of the MAINTAINERS file would still see the actual value.
Using other options of get_maintainer.pl like --sections would show
the actual content.

Other options would still show S:
> 
> Update get_maintainer to output "maintainer" for "S: Supported" the
> differentiation between paid (v) non-paid maintainers doesn't impact who
> needs to be mailed for patch submissions.
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -1283,7 +1283,7 @@ sub get_maintainer_role {
>  
>      $role = lc($role);
>      if      ($role eq "supported") {
> -	$role = "supporter";
> +	$role = "maintainer";
>      } elsif ($role eq "maintained") {
>  	$role = "maintainer";
>      } elsif ($role eq "odd fixes") {