linux-kernel - Re: [PATCH][CFT] [coredump] don't use __kernel_write() on kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yzt+xvE88/OENka+@ZenIV>
Date:   Tue, 4 Oct 2022 01:31:02 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "J. R. Okajima" <hooanon05g@...il.com>,
        Ira Weiny <ira.weiny@...el.com>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on
 kmap_local_page()

On Mon, Oct 03, 2022 at 05:20:03PM -0700, Linus Torvalds wrote:
> On Mon, Oct 3, 2022 at 4:37 PM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> > One variant would be to revert the original patch, put its
> > (hopefully) fixed variant into -next and let it sit there for
> > a while.  Another is to put this incremental into -next and
> > merge it into mainline once it gets a sane amount of testing.
> 
> Just do the incremental fix. It looks obvious enough ("oops, we need
> to get the pos _after_ we've done any skip-lseeks on the core file")
> that I think it would be just harder to follow a "revert and follow up
> with a fix".
> 
> I don't think it needs a ton of extra testing, with Okajima having
> already confirmed it fixes his problem case..

OK, incremental is in #fixes, pushed out.