Message-ID: <CAPDyKFoMidikoTPe0Xd+wZQdBBJSoy+CZ2ZmJShfLkbGZZRYDQ@mail.gmail.com>
Date:   Tue, 4 Oct 2022 13:08:00 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     juri.lelli@...hat.com, rafael@...nel.org, catalin.marinas@....com,
        linus.walleij@...aro.org, bsegall@...gle.com, guoren@...nel.org,
        pavel@....cz, agordeev@...ux.ibm.com, linux-arch@...r.kernel.org,
        vincent.guittot@...aro.org, mpe@...erman.id.au,
        chenhuacai@...nel.org, christophe.leroy@...roup.eu,
        linux-acpi@...r.kernel.org, agross@...nel.org,
        geert@...ux-m68k.org, linux-imx@....com, vgupta@...nel.org,
        mattst88@...il.com, mturquette@...libre.com, sammy@...my.net,
        pmladek@...e.com, linux-pm@...r.kernel.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-um@...ts.infradead.org, npiggin@...il.com,
        tglx@...utronix.de, linux-omap@...r.kernel.org,
        dietmar.eggemann@....com, andreyknvl@...il.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, senozhatsky@...omium.org,
        svens@...ux.ibm.com, jolsa@...nel.org, tj@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        mark.rutland@....com, linux-ia64@...r.kernel.org,
        dave.hansen@...ux.intel.com,
        virtualization@...ts.linux-foundation.org,
        James.Bottomley@...senpartnership.com, jcmvbkbc@...il.com,
        thierry.reding@...il.com, kernel@...0n.name, cl@...ux.com,
        linux-s390@...r.kernel.org, vschneid@...hat.com,
        john.ogness@...utronix.de, ysato@...rs.sourceforge.jp,
        linux-sh@...r.kernel.org, festevam@...il.com, deller@....de,
        daniel.lezcano@...aro.org, jonathanh@...dia.com, dennis@...nel.org,
        lenb@...nel.org, linux-xtensa@...ux-xtensa.org,
        kernel@...gutronix.de, gor@...ux.ibm.com,
        linux-arm-msm@...r.kernel.org, linux-alpha@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, loongarch@...ts.linux.dev,
        shorne@...il.com, chris@...kel.net, sboyd@...nel.org,
        dinguyen@...nel.org, bristot@...hat.com,
        alexander.shishkin@...ux.intel.com, fweisbec@...il.com,
        lpieralisi@...nel.org, atishp@...shpatra.org,
        linux@...musvillemoes.dk, kasan-dev@...glegroups.com,
        will@...nel.org, boris.ostrovsky@...cle.com, khilman@...nel.org,
        linux-csky@...r.kernel.org, pv-drivers@...are.com,
        linux-snps-arc@...ts.infradead.org, mgorman@...e.de,
        jacob.jun.pan@...ux.intel.com, Arnd Bergmann <arnd@...db.de>,
        ulli.kroll@...glemail.com, linux-clk@...r.kernel.org,
        rostedt@...dmis.org, ink@...assic.park.msu.ru, bcain@...cinc.com,
        tsbogend@...ha.franken.de, linux-parisc@...r.kernel.org,
        ryabinin.a.a@...il.com, sudeep.holla@....com, shawnguo@...nel.org,
        davem@...emloft.net, dalias@...c.org, tony@...mide.com,
        amakhalov@...are.com, konrad.dybcio@...ainline.org,
        bjorn.andersson@...aro.org, glider@...gle.com, hpa@...or.com,
        sparclinux@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-riscv@...ts.infradead.org, vincenzo.frascino@....com,
        anton.ivanov@...bridgegreys.com, jonas@...thpole.se,
        yury.norov@...il.com, richard@....at, x86@...nel.org,
        linux@...linux.org.uk, mingo@...hat.com, aou@...s.berkeley.edu,
        hca@...ux.ibm.com, richard.henderson@...aro.org,
        stefan.kristiansson@...nalahti.fi, openrisc@...ts.librecores.org,
        acme@...nel.org, paul.walmsley@...ive.com,
        linux-tegra@...r.kernel.org, namhyung@...nel.org,
        andriy.shevchenko@...ux.intel.com, jpoimboe@...nel.org,
        dvyukov@...gle.com, jgross@...e.com, monstr@...str.eu,
        linux-mips@...r.kernel.org, palmer@...belt.com,
        anup@...infault.org, bp@...en8.de, johannes@...solutions.net,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 23/44] arm,smp: Remove trace_.*_rcuidle() usage

On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra <peterz@...radead.org> wrote:
>
> None of these functions should ever be ran with RCU disabled anymore.
>
> Specifically, do_handle_IPI() is only called from handle_IPI() which
> explicitly does irq_enter()/irq_exit() which ensures RCU is watching.
>
> The problem with smp_cross_call() was, per commit 7c64cc0531fa ("arm: Use
> _rcuidle for smp_cross_call() tracepoints"), that
> cpuidle_enter_state_coupled() already had RCU disabled, but that's
> long been fixed by commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle
> deeper into the idle path").
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>

FWIW:

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  arch/arm/kernel/smp.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -639,7 +639,7 @@ static void do_handle_IPI(int ipinr)
>         unsigned int cpu = smp_processor_id();
>
>         if ((unsigned)ipinr < NR_IPI)
> -               trace_ipi_entry_rcuidle(ipi_types[ipinr]);
> +               trace_ipi_entry(ipi_types[ipinr]);
>
>         switch (ipinr) {
>         case IPI_WAKEUP:
> @@ -686,7 +686,7 @@ static void do_handle_IPI(int ipinr)
>         }
>
>         if ((unsigned)ipinr < NR_IPI)
> -               trace_ipi_exit_rcuidle(ipi_types[ipinr]);
> +               trace_ipi_exit(ipi_types[ipinr]);
>  }
>
>  /* Legacy version, should go away once all irqchips have been converted */
> @@ -709,7 +709,7 @@ static irqreturn_t ipi_handler(int irq,
>
>  static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
>  {
> -       trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
> +       trace_ipi_raise(target, ipi_types[ipinr]);
>         __ipi_send_mask(ipi_desc[ipinr], target);
>  }
>
>
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Powered by blists - more mailing lists