| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPDyKFqDiqXSi5Gn9eyvhHhqHxJAPAt-HzmEDwYWaGvso2yn=w@mail.gmail.com>
Date: Tue, 4 Oct 2022 13:12:42 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: juri.lelli@...hat.com, rafael@...nel.org, catalin.marinas@....com,
linus.walleij@...aro.org, bsegall@...gle.com, guoren@...nel.org,
pavel@....cz, agordeev@...ux.ibm.com, linux-arch@...r.kernel.org,
vincent.guittot@...aro.org, mpe@...erman.id.au,
chenhuacai@...nel.org, christophe.leroy@...roup.eu,
linux-acpi@...r.kernel.org, agross@...nel.org,
geert@...ux-m68k.org, linux-imx@....com, vgupta@...nel.org,
mattst88@...il.com, mturquette@...libre.com, sammy@...my.net,
pmladek@...e.com, linux-pm@...r.kernel.org,
Sascha Hauer <s.hauer@...gutronix.de>,
linux-um@...ts.infradead.org, npiggin@...il.com,
tglx@...utronix.de, linux-omap@...r.kernel.org,
dietmar.eggemann@....com, andreyknvl@...il.com,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, senozhatsky@...omium.org,
svens@...ux.ibm.com, jolsa@...nel.org, tj@...nel.org,
Andrew Morton <akpm@...ux-foundation.org>,
mark.rutland@....com, linux-ia64@...r.kernel.org,
dave.hansen@...ux.intel.com,
virtualization@...ts.linux-foundation.org,
James.Bottomley@...senpartnership.com, jcmvbkbc@...il.com,
thierry.reding@...il.com, kernel@...0n.name, cl@...ux.com,
linux-s390@...r.kernel.org, vschneid@...hat.com,
john.ogness@...utronix.de, ysato@...rs.sourceforge.jp,
linux-sh@...r.kernel.org, festevam@...il.com, deller@....de,
daniel.lezcano@...aro.org, jonathanh@...dia.com, dennis@...nel.org,
lenb@...nel.org, linux-xtensa@...ux-xtensa.org,
kernel@...gutronix.de, gor@...ux.ibm.com,
linux-arm-msm@...r.kernel.org, linux-alpha@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, loongarch@...ts.linux.dev,
shorne@...il.com, chris@...kel.net, sboyd@...nel.org,
dinguyen@...nel.org, bristot@...hat.com,
alexander.shishkin@...ux.intel.com, fweisbec@...il.com,
lpieralisi@...nel.org, atishp@...shpatra.org,
linux@...musvillemoes.dk, kasan-dev@...glegroups.com,
will@...nel.org, boris.ostrovsky@...cle.com, khilman@...nel.org,
linux-csky@...r.kernel.org, pv-drivers@...are.com,
linux-snps-arc@...ts.infradead.org, mgorman@...e.de,
jacob.jun.pan@...ux.intel.com, Arnd Bergmann <arnd@...db.de>,
ulli.kroll@...glemail.com, linux-clk@...r.kernel.org,
rostedt@...dmis.org, ink@...assic.park.msu.ru, bcain@...cinc.com,
tsbogend@...ha.franken.de, linux-parisc@...r.kernel.org,
ryabinin.a.a@...il.com, sudeep.holla@....com, shawnguo@...nel.org,
davem@...emloft.net, dalias@...c.org, tony@...mide.com,
amakhalov@...are.com, konrad.dybcio@...ainline.org,
bjorn.andersson@...aro.org, glider@...gle.com, hpa@...or.com,
sparclinux@...r.kernel.org, linux-hexagon@...r.kernel.org,
linux-riscv@...ts.infradead.org, vincenzo.frascino@....com,
anton.ivanov@...bridgegreys.com, jonas@...thpole.se,
yury.norov@...il.com, richard@....at, x86@...nel.org,
linux@...linux.org.uk, mingo@...hat.com, aou@...s.berkeley.edu,
hca@...ux.ibm.com, richard.henderson@...aro.org,
stefan.kristiansson@...nalahti.fi, openrisc@...ts.librecores.org,
acme@...nel.org, paul.walmsley@...ive.com,
linux-tegra@...r.kernel.org, namhyung@...nel.org,
andriy.shevchenko@...ux.intel.com, jpoimboe@...nel.org,
dvyukov@...gle.com, jgross@...e.com, monstr@...str.eu,
linux-mips@...r.kernel.org, palmer@...belt.com,
anup@...infault.org, bp@...en8.de, johannes@...solutions.net,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 38/44] cpuidle,powerdomain: Remove trace_.*_rcuidle()
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra <peterz@...radead.org> wrote:
>
> OMAP was the one and only user.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
There are changes to the runtime PM core as part of $subject patch.
Perhaps move those parts into a separate patch? In any case, the code
looks good to me.
Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
Kind regards
Uffe
> ---
> arch/arm/mach-omap2/powerdomain.c | 10 +++++-----
> drivers/base/power/runtime.c | 24 ++++++++++++------------
> 2 files changed, 17 insertions(+), 17 deletions(-)
>
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -187,9 +187,9 @@ static int _pwrdm_state_switch(struct po
> trace_state = (PWRDM_TRACE_STATES_FLAG |
> ((next & OMAP_POWERSTATE_MASK) << 8) |
> ((prev & OMAP_POWERSTATE_MASK) << 0));
> - trace_power_domain_target_rcuidle(pwrdm->name,
> - trace_state,
> - raw_smp_processor_id());
> + trace_power_domain_target(pwrdm->name,
> + trace_state,
> + raw_smp_processor_id());
> }
> break;
> default:
> @@ -541,8 +541,8 @@ int pwrdm_set_next_pwrst(struct powerdom
>
> if (arch_pwrdm && arch_pwrdm->pwrdm_set_next_pwrst) {
> /* Trace the pwrdm desired target state */
> - trace_power_domain_target_rcuidle(pwrdm->name, pwrst,
> - raw_smp_processor_id());
> + trace_power_domain_target(pwrdm->name, pwrst,
> + raw_smp_processor_id());
> /* Program the pwrdm desired target state */
> ret = arch_pwrdm->pwrdm_set_next_pwrst(pwrdm, pwrst);
> }
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -442,7 +442,7 @@ static int rpm_idle(struct device *dev,
> int (*callback)(struct device *);
> int retval;
>
> - trace_rpm_idle_rcuidle(dev, rpmflags);
> + trace_rpm_idle(dev, rpmflags);
> retval = rpm_check_suspend_allowed(dev);
> if (retval < 0)
> ; /* Conditions are wrong. */
> @@ -481,7 +481,7 @@ static int rpm_idle(struct device *dev,
> dev->power.request_pending = true;
> queue_work(pm_wq, &dev->power.work);
> }
> - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, 0);
> + trace_rpm_return_int(dev, _THIS_IP_, 0);
> return 0;
> }
>
> @@ -493,7 +493,7 @@ static int rpm_idle(struct device *dev,
> wake_up_all(&dev->power.wait_queue);
>
> out:
> - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval);
> + trace_rpm_return_int(dev, _THIS_IP_, retval);
> return retval ? retval : rpm_suspend(dev, rpmflags | RPM_AUTO);
> }
>
> @@ -557,7 +557,7 @@ static int rpm_suspend(struct device *de
> struct device *parent = NULL;
> int retval;
>
> - trace_rpm_suspend_rcuidle(dev, rpmflags);
> + trace_rpm_suspend(dev, rpmflags);
>
> repeat:
> retval = rpm_check_suspend_allowed(dev);
> @@ -708,7 +708,7 @@ static int rpm_suspend(struct device *de
> }
>
> out:
> - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval);
> + trace_rpm_return_int(dev, _THIS_IP_, retval);
>
> return retval;
>
> @@ -760,7 +760,7 @@ static int rpm_resume(struct device *dev
> struct device *parent = NULL;
> int retval = 0;
>
> - trace_rpm_resume_rcuidle(dev, rpmflags);
> + trace_rpm_resume(dev, rpmflags);
>
> repeat:
> if (dev->power.runtime_error) {
> @@ -925,7 +925,7 @@ static int rpm_resume(struct device *dev
> spin_lock_irq(&dev->power.lock);
> }
>
> - trace_rpm_return_int_rcuidle(dev, _THIS_IP_, retval);
> + trace_rpm_return_int(dev, _THIS_IP_, retval);
>
> return retval;
> }
> @@ -1081,7 +1081,7 @@ int __pm_runtime_idle(struct device *dev
> if (retval < 0) {
> return retval;
> } else if (retval > 0) {
> - trace_rpm_usage_rcuidle(dev, rpmflags);
> + trace_rpm_usage(dev, rpmflags);
> return 0;
> }
> }
> @@ -1119,7 +1119,7 @@ int __pm_runtime_suspend(struct device *
> if (retval < 0) {
> return retval;
> } else if (retval > 0) {
> - trace_rpm_usage_rcuidle(dev, rpmflags);
> + trace_rpm_usage(dev, rpmflags);
> return 0;
> }
> }
> @@ -1202,7 +1202,7 @@ int pm_runtime_get_if_active(struct devi
> } else {
> retval = atomic_inc_not_zero(&dev->power.usage_count);
> }
> - trace_rpm_usage_rcuidle(dev, 0);
> + trace_rpm_usage(dev, 0);
> spin_unlock_irqrestore(&dev->power.lock, flags);
>
> return retval;
> @@ -1566,7 +1566,7 @@ void pm_runtime_allow(struct device *dev
> if (ret == 0)
> rpm_idle(dev, RPM_AUTO | RPM_ASYNC);
> else if (ret > 0)
> - trace_rpm_usage_rcuidle(dev, RPM_AUTO | RPM_ASYNC);
> + trace_rpm_usage(dev, RPM_AUTO | RPM_ASYNC);
>
> out:
> spin_unlock_irq(&dev->power.lock);
> @@ -1635,7 +1635,7 @@ static void update_autosuspend(struct de
> atomic_inc(&dev->power.usage_count);
> rpm_resume(dev, 0);
> } else {
> - trace_rpm_usage_rcuidle(dev, 0);
> + trace_rpm_usage(dev, 0);
> }
> }
>
>
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Powered by blists - more mailing lists