linux-kernel - Re: [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c99ca249-7135-1313-8cc4-e6d3c3f85d2a@alliedtelesis.co.nz>
Date:   Tue, 4 Oct 2022 01:13:03 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     "andrew@...n.ch" <andrew@...n.ch>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: armada-xp-98dx3236: add interrupts for watchdog

Hi All,

On 4/10/22 10:24, Chris Packham wrote:
> The first interrupt is for the regular watchdog timeout. Normally the
> RSTOUT line will trigger a reset before this interrupt fires but on
> systems with a non-standard reset it may still trigger.
>
> The second interrupt is for a timer1 which is used as a pre-timeout for
> the watchdog.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

I just realized this is a duplicate of 
https://lore.kernel.org/linux-watchdog/20220211003257.2037332-2-chris.packham@alliedtelesis.co.nz/ 
(I did have a strange sense of deja vu when writing it).

Looks like that patch was reviewed and acked but never delivered. 
Gregory would you be able to pick it up now? The driver change has been 
in for a while.

> ---
>   arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> index 38a052a0312d..0e561dfc0ca9 100644
> --- a/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-98dx3236.dtsi
> @@ -286,6 +286,7 @@ &watchdog {
>   	compatible = "marvell,armada-xp-wdt";
>   	clocks = <&coreclk 2>, <&refclk>;
>   	clock-names = "nbclk", "fixed";
> +	interrupts = <93>, <38>;
>   };
>   
>   &cpurst {