linux-kernel - Re: [PATCH v3] staging: rtl8712: fix potential memory leak in _r8712_init_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yzw3G8rPsW1TMhPW@kadam>
Date:   Tue, 4 Oct 2022 16:37:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Xiaoke Wang <xkernel.wang@...mail.com>
Cc:     "Larry.Finger" <Larry.Finger@...inger.net>,
        "florian.c.schilhabel" <florian.c.schilhabel@...glemail.com>,
        gregkh <gregkh@...uxfoundation.org>,
        linux-staging <linux-staging@...ts.linux.dev>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] staging: rtl8712: fix potential memory leak in
 _r8712_init_xmit_priv()

On Tue, Sep 27, 2022 at 08:55:08PM +0800, Xiaoke Wang wrote:
> 
> Yes, the memory address is still on the list, and at the above position of
> `Note`, the address of `pxmitpriv-&gt;pallocated_frame_buf` is also left on a
> list named `pxmitpriv-&gt;free_xmit_queue`.
> However, these lists are in `pxmitpriv` and this function is for
> initializing `pxmitpriv`. When this function fails, the probe function of
> this driver will finally fail. So I guess the list in `pxmitpriv` will not
> be accessed.

Sorry for the delayed response.  I think you are right.  This patch is
fine then.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter