linux-kernel - Re: [PATCH 4/5] thermal/core: Move the thermal zone lock out of the governors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <317e3cf1-2e20-d5ec-1bdc-f8537a8231d1@linaro.org>
Date:   Tue, 4 Oct 2022 16:21:12 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     rafael@...nel.org, rui.zhang@...el.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Amit Kucheria <amitk@...nel.org>,
        Lukasz Luba <lukasz.luba@....com>
Subject: Re: [PATCH 4/5] thermal/core: Move the thermal zone lock out of the
 governors

On 04/10/2022 16:14, Guenter Roeck wrote:
> On Fri, Aug 05, 2022 at 05:38:33PM +0200, Daniel Lezcano wrote:
>> All the governors throttling ops are taking/releasing the lock at the
>> beginning and the end of the function.
>>
>> We can move the mutex to the throttling call site instead.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>> ---
>>   drivers/thermal/gov_bang_bang.c       |  4 +---
>>   drivers/thermal/gov_fair_share.c      |  4 +---
>>   drivers/thermal/gov_power_allocator.c | 16 ++++++----------
>>   drivers/thermal/gov_step_wise.c       |  4 +---
>>   drivers/thermal/thermal_core.c        |  2 ++
> 
> This doesn't drop the lock from drivers/thermal/gov_user_space.c.
> Is that on purpose ?

No, it is an oversight. It was fixed after by Rafael

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog