linux-kernel - Re: [PATCH -next] drm/msm: Remove unused variables 'top'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa74e1c0-53bb-4e73-4df5-c69cd455dd11@quicinc.com>
Date:   Tue, 4 Oct 2022 09:27:56 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Chen Zhongjin <chenzhongjin@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>
CC:     <dianders@...omium.org>, <sean@...rly.run>, <andersson@...nel.org>,
        <swboyd@...omium.org>, <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH -next] drm/msm: Remove unused variables 'top'



On 10/9/2022 7:40 PM, Chen Zhongjin wrote:
> 'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct dpu_hw_blk_reg_map")'
> 'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map")'
> These commits had merged hw.blk_off and hw.blk_off to mdp.
> So we don't need to get dpu_hw_mdp in dpu_kms_mdp_snapshot() now.
> 
> Since there is no code using 'top' in this function. Remove it.
> 
> Signed-off-by: Chen Zhongjin <chenzhongjin@...wei.com>

This has already been fixed with:

https://gitlab.freedesktop.org/drm/msm/-/commit/4bca876458caf7c105ab2ae9d80ff2cc9c60388d


> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 008e1420e6e5..79e81f1443be 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -902,13 +902,9 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
>   	int i;
>   	struct dpu_kms *dpu_kms;
>   	const struct dpu_mdss_cfg *cat;
> -	struct dpu_hw_mdp *top;
>   
>   	dpu_kms = to_dpu_kms(kms);
> -
>   	cat = dpu_kms->catalog;
> -	top = dpu_kms->hw_mdp;
> -
>   	pm_runtime_get_sync(&dpu_kms->pdev->dev);
>   
>   	/* dump CTL sub-blocks HW regs info */