linux-kernel - [RFC PATCH 16/21] mmc: core: use lib tagset init helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 20:22:52 -0700
From:   Chaitanya Kulkarni <kch@...dia.com>
To:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>
CC:     <axboe@...nel.dk>, <efremov@...ux.com>, <josef@...icpanda.com>,
        <idryomov@...il.com>, <dongsheng.yang@...ystack.cn>,
        <haris.iqbal@...os.com>, <jinpu.wang@...os.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <pbonzini@...hat.com>,
        <stefanha@...hat.com>, <ohad@...ery.com>, <andersson@...nel.org>,
        <baolin.wang@...ux.alibaba.com>, <ulf.hansson@...aro.org>,
        <richard@....at>, <miquel.raynal@...tlin.com>, <vigneshr@...com>,
        <marcan@...can.st>, <sven@...npeter.dev>, <alyssa@...enzweig.io>,
        <kbusch@...nel.org>, <hch@....de>, <sagi@...mberg.me>,
        <sth@...ux.ibm.com>, <hoeppner@...ux.ibm.com>, <hca@...ux.ibm.com>,
        <gor@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
        <borntraeger@...ux.ibm.com>, <svens@...ux.ibm.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
        <kch@...dia.com>, <bhelgaas@...gle.com>, <john.garry@...wei.com>,
        <mcgrof@...nel.org>, <christophe.jaillet@...adoo.fr>,
        <vaibhavgupta40@...il.com>, <wsa+renesas@...g-engineering.com>,
        <damien.lemoal@...nsource.wdc.com>, <johannes.thumshirn@....com>,
        <bvanassche@....org>, <ming.lei@...hat.com>,
        <shinichiro.kawasaki@....com>, <vincent.fu@...sung.com>,
        <christoph.boehmwalder@...bit.com>, <joel@....id.au>,
        <vincent.whitchurch@...s.com>, <nbd@...er.debian.org>,
        <ceph-devel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        <asahi@...ts.linux.dev>
Subject: [RFC PATCH 16/21] mmc: core: use lib tagset init helper

Use the block layer helper to initialize the common fields of tag_set
such as blk_mq_ops, number of h/w queues, queue depth, command size,
numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
is spread all over the block drivers. This avoids the code repetation of
the inialization code of the tag set in current block drivers and any
future ones.

Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
---
 drivers/mmc/core/queue.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index fefaa901b50f..599a34a5680a 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -417,7 +417,6 @@ struct gendisk *mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card)
 	spin_lock_init(&mq->lock);
 
 	memset(&mq->tag_set, 0, sizeof(mq->tag_set));
-	mq->tag_set.ops = &mmc_mq_ops;
 	/*
 	 * The queue depth for CQE must match the hardware because the request
 	 * tag is used to index the hardware queue.
@@ -427,11 +426,9 @@ struct gendisk *mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card)
 			min_t(int, card->ext_csd.cmdq_depth, host->cqe_qdepth);
 	else
 		mq->tag_set.queue_depth = MMC_QUEUE_DEPTH;
-	mq->tag_set.numa_node = NUMA_NO_NODE;
-	mq->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_BLOCKING;
-	mq->tag_set.nr_hw_queues = 1;
-	mq->tag_set.cmd_size = sizeof(struct mmc_queue_req);
-	mq->tag_set.driver_data = mq;
+	blk_mq_init_tag_set(&mq->tag_set, &mmc_mq_ops, 1, 0,
+			sizeof(struct mmc_queue_req), NUMA_NO_NODE, 0,
+			BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_BLOCKING, mq);
 
 	/*
 	 * Since blk_mq_alloc_tag_set() calls .init_request() of mmc_mq_ops,
-- 
2.29.0