linux-kernel - Re: [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Oct 2022 13:46:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Richard Acayan <mailingradian@...il.com>,
        linux-arm-msm@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Richard Acayan <mailingradian@...il.com>,
        Lee Jones <lee@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v7 3/3] pinctrl: qcom: add sdm670 pinctrl

Hi Richard,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v6.0 next-20221004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Richard-Acayan/SDM670-Pin-Control-Driver/20221005-055945
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm-allyesconfig
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a5fc454b25ce096d492361bc30fa82560d0c1270
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Richard-Acayan/SDM670-Pin-Control-Driver/20221005-055945
        git checkout a5fc454b25ce096d492361bc30fa82560d0c1270
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pinctrl/qcom/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/qcom/pinctrl-sdm670.c:1310:10: error: 'const struct msm_pinctrl_soc_data' has no member named 'complement_fw_gpio_ranges'
    1310 |         .complement_fw_gpio_ranges = true,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/qcom/pinctrl-sdm670.c:1310:38: warning: initialization of 'const struct msm_gpio_wakeirq_map *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1310 |         .complement_fw_gpio_ranges = true,
         |                                      ^~~~
   drivers/pinctrl/qcom/pinctrl-sdm670.c:1310:38: note: (near initialization for 'sdm670_pinctrl.wakeirq_map')


vim +1310 drivers/pinctrl/qcom/pinctrl-sdm670.c

  1300	
  1301	static const struct msm_pinctrl_soc_data sdm670_pinctrl = {
  1302		.pins = sdm670_pins,
  1303		.npins = ARRAY_SIZE(sdm670_pins),
  1304		.functions = sdm670_functions,
  1305		.nfunctions = ARRAY_SIZE(sdm670_functions),
  1306		.groups = sdm670_groups,
  1307		.ngroups = ARRAY_SIZE(sdm670_groups),
  1308		.ngpios = 151,
  1309		.reserved_gpios = sdm670_reserved_gpios,
> 1310		.complement_fw_gpio_ranges = true,
  1311	};
  1312	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (358628 bytes)