linux-kernel - RE: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <087811c1bc224a468f117ca4f2fff3cd@ite.com.tw>
Date:   Wed, 5 Oct 2022 06:19:39 +0000
From:   <allen.chen@....com.tw>
To:     <neil.armstrong@...aro.org>
CC:     <devicetree@...r.kernel.org>, <Kenneth.Hung@....com.tw>,
        <jernej.skrabec@...il.com>, <krzysztof.kozlowski+dt@...aro.org>,
        <Jau-Chih.Tseng@....com.tw>, <airlied@...ux.ie>,
        <dri-devel@...ts.freedesktop.org>, <narmstrong@...libre.com>,
        <linux-kernel@...r.kernel.org>, <robert.foss@...aro.org>,
        <treapking@...omium.org>, <Hermes.Wu@....com.tw>,
        <robh+dt@...nel.org>, <Laurent.pinchart@...asonboard.com>,
        <andrzej.hajda@...el.com>, <jonas@...boo.se>
Subject: RE: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict
 output bandwidth

Hi

data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint.
extcon doesn't have output endpoint, so I don't know where to put is better.

-----Original Message-----
From: Neil Armstrong <neil.armstrong@...aro.org> 
Sent: Thursday, September 29, 2022 4:40 PM
To: Allen Chen (陳柏宇) <allen.chen@....com.tw>
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>; Kenneth Hung (洪家倫) <Kenneth.Hung@....com.tw>; Jernej Skrabec <jernej.skrabec@...il.com>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@....com.tw>; David Airlie <airlied@...ux.ie>; open list:DRM DRIVERS <dri-devel@...ts.freedesktop.org>; Neil Armstrong <narmstrong@...libre.com>; open list <linux-kernel@...r.kernel.org>; Robert Foss <robert.foss@...aro.org>; Pin-yen Lin <treapking@...omium.org>; Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>; Rob Herring <robh+dt@...nel.org>; Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Andrzej Hajda <andrzej.hajda@...el.com>; Jonas Karlman <jonas@...boo.se>
Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

Hi,

On 29/09/2022 03:44, allen wrote:
> From: allen chen <allen.chen@....com.tw>
> 
> Add properties to restrict dp output data-lanes and clock.
> 
> Signed-off-by: Pin-Yen Lin <treapking@...omium.org>
> Signed-off-by: Allen Chen <allen.chen@....com.tw>
> ---
>   .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml 
> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a..62b9f2192202 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,14 @@ properties:
>       maxItems: 1
>       description: extcon specifier for the Power Delivery
>   
> +  data-lanes:
> +    maxItems: 1
> +    description: restrict the dp output data-lanes with value of 1-4

Can't you use the data-lanes property in the first port endpoint ?

Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

> +
> +  max-pixel-clock-khz:
> +    maxItems: 1
> +    description: restrict max pixel clock

New vendor specific properties should have the ite, prefix.

> +
>     port:
>       $ref: /schemas/graph.yaml#/properties/port
>       description: A port node pointing to DPI host port node @@ -84,6 
> +92,8 @@ examples:
>               pwr18-supply = <&it6505_pp18_reg>;
>               reset-gpios = <&pio 179 1>;
>               extcon = <&usbc_extcon>;
> +            data-lanes = <2>;
> +            max-pixel-clock-khz = <150000>;
>   
>               port {
>                   it6505_in: endpoint {

Thanks,
Neil