lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ffc56eb60a3ef74c815c8d3c170a0df51958e20d.camel@mediatek.com>
Date:   Wed, 5 Oct 2022 07:21:18 +0000
From:   Allen-KH Cheng (程冠勳) 
        <Allen-KH.Cheng@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH v4 1/2] media: dt-bindings: mediatek: Rename child node
 names for decoder

Hi Rob,

On Fri, 2022-09-30 at 17:00 -0500, Rob Herring wrote:
> On Fri, Sep 30, 2022 at 07:22:36PM +0800, Allen-KH Cheng wrote:
> > In order to make the names of the child nodes more generic, we
> > rename
> > "vcodec" to "video-codec" for decoder in patternProperties and
> > example.
> 
> They are either generic or they aren't. Until something generic is 
> defined, I don't think it's worth the churn to change.
> 
> 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > ---
> >  .../bindings/media/mediatek,vcodec-subdev-decoder.yaml    | 8
> > ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index c4f20acdc1f8..67fde48f991c 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -91,7 +91,7 @@ properties:
> >  
> >  # Required child node:
> >  patternProperties:
> > -  '^vcodec-lat@[0-9a-f]+$':
> > +  '^video-codec-lat@[0-9a-f]+$':
> 
> Just 'video-codec' doesn't work?
> 

Thanks for your reply.

hmm, I think 'vidoe-codec' does wrok.

There are two seperate hardwares for the MTK video codec.
codec-lat and codec-core.

Is it ok to keep two child node names for various hardwares?


Thanks,
Allen

> >      type: object
> >  
> >      properties:
> > @@ -145,7 +145,7 @@ patternProperties:
> >  
> >      additionalProperties: false
> >  
> > -  '^vcodec-core@[0-9a-f]+$':
> > +  '^video-codec-core@[0-9a-f]+$':
> >      type: object
> >  
> >      properties:
> > @@ -241,7 +241,7 @@ examples:
> >              #size-cells = <2>;
> >              ranges = <0 0 0 0x16000000 0 0x40000>;
> >              reg = <0 0x16000000 0 0x1000>;		/* VDEC_SYS */
> > -            vcodec-lat@...00 {
> > +            video-codec-lat@...00 {
> >                  compatible = "mediatek,mtk-vcodec-lat";
> >                  reg = <0 0x10000 0 0x800>;
> >                  interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
> > @@ -264,7 +264,7 @@ examples:
> >                  power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
> >              };
> >  
> > -            vcodec-core@...00 {
> > +            video-codec-core@...00 {
> >                  compatible = "mediatek,mtk-vcodec-core";
> >                  reg = <0 0x25000 0 0x1000>;
> >                  interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>;
> > -- 
> > 2.18.0
> > 
> > 

Powered by blists - more mailing lists