linux-kernel - Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of the charger in the example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Oct 2022 16:14:11 +0800
From:   ChiaEn Wu <peterwu.pub@...il.com>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        matthias.bgg@...il.com, sre@...nel.org, chiaen_wu@...htek.com,
        cy_huang@...htek.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of
 the charger in the example

On Mon, Oct 3, 2022 at 11:34 PM Rob Herring <robh+dt@...nel.org> wrote:
>

...

>
> This doesn't fix all the warnings. These still remain:
>
> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
> pmic@34: indicator: 'color' is a required property
>         From schema:
> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
> indicator: $nodename:0: 'indicator' does not match
> '^multi-led(@[0-9a-f])?$'
>         From schema:
> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml

Hi Rob,

In my opinion, the root cause of these warnings is the incorrect usage
of 'allOf' in our LED indicator dts as follows,
(https://lore.kernel.org/all/27df85c30277a171ae85ff6d5b7d867625765d0a.1663926551.git.chiaen_wu@richtek.com/)
----------
+allOf:
+  - $ref: leds-class-multicolor.yaml#
+
+properties:
+  compatible:
+    const: mediatek,mt6370-indicator
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^multi-led@[0-3]$":
+    type: object
----------

and this patch for Linux 6.0
(https://lore.kernel.org/all/20220624112106.111351-1-krzysztof.kozlowski@linaro.org/)

I will revise our LED indicator dts in the next version(v13) of
'MT6370 patch series' like this,
----------
// Remove 'allOf'

+properties:
+  compatible:
+    const: mediatek,mt6370-indicator
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^multi-led@[0-3]$":
+    type: object
+    $ref: leds-class-multicolor.yaml#          // Add this line
+    unevaluatedProperties: false               // Add this line
----------

And this '[PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order
of the charger in the example' patch is for fix charger example in MFD
dts.
Thank you so much.

-- 
Best Regards,
ChiaEn Wu