linux-kernel - Re: [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing experimental data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89aed08f-1e0b-258c-516d-97a30fd02840@gmail.com>
Date:   Wed, 5 Oct 2022 16:32:23 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>, rppt@...nel.org
Cc:     akiyks@...il.com, akpm@...ux-foundation.org, corbet@....net,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org, yejiajian2018@...il.szu.edu.cn,
        zhangyinan2019@...il.szu.edu.cn
Subject: Re: [PATCH v2] Documentation/mm/page_owner.rst: delete frequently
 changing experimental data

On 10/5/22 16:10, Yixuan Cao wrote:
> Thanks for Jonathan Corbet, Bagas Sanjaya and Mike Rapoport's
> constructive suggestions. Notice that the size(1) output is
> changing frequently, I remove the two tables and describe them
> in a general way. Doing so avoids having to repeatedly maintain
> the two tables due to kernel changes.
> 

For the patch description, better write:

"The kernel size changes due to many factors, such as compiler
 version, configuration, and the build environment. This makes
 size comparison figures irrelevant to reader's setup.

 Remove these figures and describe the effects of page owner
 to the kernel size in general instead."

> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>
> ---
>  Documentation/mm/page_owner.rst | 20 ++++----------------
>  1 file changed, 4 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
> index f18fd8907049..1b661ad85647 100644
> --- a/Documentation/mm/page_owner.rst
> +++ b/Documentation/mm/page_owner.rst
> @@ -38,22 +38,10 @@ not affect to allocation performance, especially if the static keys jump
>  label patching functionality is available. Following is the kernel's code
>  size change due to this facility.
>  
> -- Without page owner::
> -
> -   text    data     bss     dec     hex filename
> -   48392   2333     644   51369    c8a9 mm/page_alloc.o
> -
> -- With page owner::
> -
> -   text    data     bss     dec     hex filename
> -   48800   2445     644   51889    cab1 mm/page_alloc.o
> -   6662     108      29    6799    1a8f mm/page_owner.o
> -   1025       8       8    1041     411 mm/page_ext.o
> -
> -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> -520 bytes and less than half of it is in hotpath. Building the kernel with
> -page owner and turning it on if needed would be great option to debug
> -kernel memory problem.
> +Although, enabling page owner increases kernel size by several kilobytes,
> +most of this code is outside page allocator and its hot path. Building 
> +the kernel with page owner and turning it on if needed would be great
> +option to debug kernel memory problem.
>  

s/Although,/Although/

Thanks for reviewing.

-- 
An old man doll... just what I always wanted! - Clara