linux-kernel - [kbuild] drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown() error: uninitialized symbol 'wake'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202210051608.le3wSeQi-lkp@intel.com>
Date:   Wed, 5 Oct 2022 13:05:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Mengyuan Lou <mengyuanlou@...-swift.com>
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: [kbuild] drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54
 ngbe_shutdown() error: uninitialized symbol 'wake'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git   master
head:   2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
commit: e79e40c83b9fd4e8b9b9d4fc9093d25b7a67c745 net: ngbe: Add build support for ngbe
config: powerpc-randconfig-m041-20221002
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown() error: uninitialized symbol 'wake'.

vim +/wake +54 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c

e79e40c83b9fd4 Mengyuan Lou 2022-08-26  47  static void ngbe_shutdown(struct pci_dev *pdev)
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  48  {
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  49  	bool wake;
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  50  
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  51  	ngbe_dev_shutdown(pdev, &wake);

ngbe_dev_shutdown() does not do anything to wake.

e79e40c83b9fd4 Mengyuan Lou 2022-08-26  52  
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  53  	if (system_state == SYSTEM_POWER_OFF) {
e79e40c83b9fd4 Mengyuan Lou 2022-08-26 @54  		pci_wake_from_d3(pdev, wake);
                                                                               ^^^^
Uninitialized.


e79e40c83b9fd4 Mengyuan Lou 2022-08-26  55  		pci_set_power_state(pdev, PCI_D3hot);
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  56  	}
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  57  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp