linux-kernel - Re: [PATCH v4 1/2] media: dt-bindings: mediatek: Rename child node names for decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <722194a3d413ca15069554ebab1f34dec25057eb.camel@mediatek.com>
Date:   Wed, 5 Oct 2022 11:58:17 +0000
From:   Allen-KH Cheng (程冠勳) 
        <Allen-KH.Cheng@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH v4 1/2] media: dt-bindings: mediatek: Rename child node
 names for decoder

Hi Krzysztof,

On Wed, 2022-10-05 at 09:30 +0200, Krzysztof Kozlowski wrote:
> On 05/10/2022 09:21, Allen-KH Cheng (程冠勳) wrote:
> > Hi Rob,
> > 
> > On Fri, 2022-09-30 at 17:00 -0500, Rob Herring wrote:
> > > On Fri, Sep 30, 2022 at 07:22:36PM +0800, Allen-KH Cheng wrote:
> > > > In order to make the names of the child nodes more generic, we
> > > > rename
> > > > "vcodec" to "video-codec" for decoder in patternProperties and
> > > > example.
> > > 
> > > They are either generic or they aren't. Until something generic
> > > is 
> > > defined, I don't think it's worth the churn to change.
> > > 
> > > 
> > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> > > > Reviewed-by: AngeloGioacchino Del Regno <
> > > > angelogioacchino.delregno@...labora.com>
> > > > ---
> > > >  .../bindings/media/mediatek,vcodec-subdev-decoder.yaml    | 8
> > > > ++++----
> > > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > subdev-
> > > > decoder.yaml
> > > > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > subdev-
> > > > decoder.yaml
> > > > index c4f20acdc1f8..67fde48f991c 100644
> > > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > subdev-decoder.yaml
> > > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > > > subdev-decoder.yaml
> > > > @@ -91,7 +91,7 @@ properties:
> > > >  
> > > >  # Required child node:
> > > >  patternProperties:
> > > > -  '^vcodec-lat@[0-9a-f]+$':
> > > > +  '^video-codec-lat@[0-9a-f]+$':
> > > 
> > > Just 'video-codec' doesn't work?
> > > 
> > 
> > Thanks for your reply.
> > 
> > hmm, I think 'vidoe-codec' does wrok.
> > 
> > There are two seperate hardwares for the MTK video codec.
> > codec-lat and codec-core.
> > 
> > Is it ok to keep two child node names for various hardwares?
> > 
> 
> Aren't they still codecs?
> 
> Best regards,
> Krzysztof

Yes, They are both hardware deocders. Lat is responsible for the
bitstream and write the outcome to the lat buffer. Core will decode the
lat buffer and write the outcome to the output buffer. Each frame will
be decoded cyclically by these two hardware deocders.


Thanks,
Allen


>