linux-kernel - Re: build failure of next-20221005 due to 4078ec1ef5ed ("LoongArch: Use TLB for ioremap()")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Oct 2022 22:06:56 +0800
From:   Xi Ruoyao <xry111@...111.site>
To:     Huacai Chen <chenhuacai@...ngson.cn>
Cc:     WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: Re: build failure of next-20221005 due to 4078ec1ef5ed ("LoongArch:
 Use TLB for ioremap()")

Hi Huacai,

Try:

#define iounmap(addr) ((void)(addr))

This is how we normally silence an unused variable or parameter warning.
Not sure if the kernel uses the same convention though.

On Wed, 2022-10-05 at 13:54 +0100, Sudip Mukherjee wrote:
> On Wed, Oct 5, 2022 at 1:30 PM Huacai Chen <chenhuacai@...nel.org>
> wrote:
> > 
> > Hi, Sudip,
> > 
> > This seems a false positive. When the implementation of iounmap() is
> > empty (but this is completely legal I think), these drivers will
> > cause
> > "unused variable error".
> 
> And that error will fail the build as allmodconfig will have
> CONFIG_WERROR=y.
> 

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University