linux-kernel - Re: [PATCH] ACPI: APEI: Fix num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jM8WrE1u1x5K26Lj0kEvRfQB=nk4vOXYEnoG-zeuywRw@mail.gmail.com>
Date:   Wed, 5 Oct 2022 17:49:40 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ashish Kalra <Ashish.Kalra@....com>
Cc:     bp@...en8.de, devel@...ica.org, james.morse@....com,
        lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, rafael@...nel.org,
        robert.moore@...el.com, tony.luck@...el.com
Subject: Re: [PATCH] ACPI: APEI: Fix num_ghes to unsigned int

On Wed, Oct 5, 2022 at 5:41 PM Ashish Kalra <Ashish.Kalra@....com> wrote:
>
> Yes, on one of our AMD EPYC processors, num_ghes is 32776 and we get the following call trace due to vmalloc() failure beacuse of the overflow:

But int should be more than sufficient to accommodate that number.

I think that the overflow takes place during the execution of this statement:

len += (num_ghes * GHES_ESOURCE_PREALLOC_MAX_SIZE);

because the right-hand side of it is of type int, because both
multiplication operands are int.

You should say that in the changelog.