linux-kernel - Re: [PATCH 1/2] ASoC: dt-bindings: add pin-switches to audio-graph-card2.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <365e37ca-1c70-93ae-8507-35f08639088f@linaro.org>
Date:   Wed, 5 Oct 2022 18:06:13 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Claudio Cabral <CLCA@...g-olufsen.dk>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Alvin Šipraga <ALSI@...g-olufsen.dk>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: add pin-switches to
 audio-graph-card2.yaml

On 05/10/2022 16:27, Claudio Cabral wrote:
> Document support for pin-switches in audio-graph-card2

Full stop?

> this devicetree property behaves the same way as its homonym in
> simple-card

Missing capital letter and full stop?

Instead please describe why do you need pin-switches in this binding...

> 
> Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Authorship or contributions (SoB) usually means someone reviewed it and
there is no need for both tags. The combination of both tags above is a
bit surprising.

> Signed-off-by: Claudio Cabral <clca@...g-olufsen.dk>
> ---
>  Documentation/devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Best regards,
Krzysztof