lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Oct 2022 10:32:25 -0700 From: Axel Rasmussen <axelrasmussen@...gle.com> To: Peter Xu <peterx@...hat.com> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, Mike Kravetz <mike.kravetz@...cle.com> Subject: Re: [PATCH 1/4] selftests/vm: Use memfd for hugetlb tests On Wed, Oct 5, 2022 at 7:44 AM Peter Xu <peterx@...hat.com> wrote: > > On Tue, Oct 04, 2022 at 03:04:23PM -0700, Axel Rasmussen wrote: > > We should also update the examples / help text near the top of the > > file, since we're changing what arguments this accepts. > > Definitely, I missed that. > > > > > It might also be better to squash the changes to test arguments in > > run_vmtests.sh into each patch, so if we're bisecting we'll have a > > matching / working test + run_vmtests.sh combo at each commit. > > I can do that, but may not be required - note that I did the first three > patches just to make sure they're still compatible with the old cmdlines, > by ignoring the extra params. Ah! In that case, forget it. :) > > [...] > > > This is a nice simplification! Thanks for doing it. Besides the > > comments above, the rest of the code here looks correct to me. Feel > > free to take: > > > > Reviewed-by: Axel Rasmussen <axelrasmussen@...gle.com> > > Thanks! > > -- > Peter Xu >
Powered by blists - more mailing lists