linux-kernel - Re: [PATCH][next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yz3So27pgqX92viW@shikoro>
Date:   Wed, 5 Oct 2022 20:53:23 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>,
        Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM
 against an unsigned variable

On Tue, Oct 04, 2022 at 08:27:15PM +0100, Colin Ian King wrote:
> The comparison of variable ret with -EPERM is always false because
> ret is an u8 type. Fix this by making ret an int.
> 
> Cleans up clang warning:
> drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison
> of constant -1 with expression of type 'u8' (aka 'unsigned char') is always
> false [-Wtautological-constant-out-of-range-compare]
> 
> Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)