linux-kernel - Re: mainline build failure due to 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Oct 2022 22:04:15 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: mainline build failure due to 81c0386c1376 ("regmap: mmio:
 Support accelerared noinc operations")

On Wed, Oct 5, 2022 at 12:39 PM Mark Brown <broonie@...nel.org> wrote:
> On Wed, Oct 05, 2022 at 07:30:56AM +0100, Sudip Mukherjee (Codethink) wrote:
> > Hi All,
> >
> > The latest mainline kernel branch fails to build alpha allmodconfig
> > with the error:
> >
> > drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_noinc_write':
> > drivers/base/regmap/regmap-mmio.c:222:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
> >   222 |                 writesb(ctx->regs + reg, (const u8 *)val, val_count);
> >       |                 ^~~~~~~
> >       |                 writeb
>
> I'd forgotten about this one, sorry, and alpha isn't covered by things
> like KernelCI so I didn't see the failure when I checked before sending
> my pull request.  It's fixed in -next by 7e772dad9913992 ("alpha: Use
> generic <asm-generic/io.h>") from Linus Walleij which is in the
> asm-generic tree.

There were some further issues with the fix (alpha is really hairy)
but Arnd stepped in and fixed those too, it should all be fixed up when
the arch tree gets pulled.

This was the first time I had to do generic arch maintenance duty so
it was a bit bumpy.

Yours,
Linus Walleij