linux-kernel - [RFC PATCH 02/21] loop: use lib tagset init helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 20:22:38 -0700
From:   Chaitanya Kulkarni <kch@...dia.com>
To:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>
CC:     <axboe@...nel.dk>, <efremov@...ux.com>, <josef@...icpanda.com>,
        <idryomov@...il.com>, <dongsheng.yang@...ystack.cn>,
        <haris.iqbal@...os.com>, <jinpu.wang@...os.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <pbonzini@...hat.com>,
        <stefanha@...hat.com>, <ohad@...ery.com>, <andersson@...nel.org>,
        <baolin.wang@...ux.alibaba.com>, <ulf.hansson@...aro.org>,
        <richard@....at>, <miquel.raynal@...tlin.com>, <vigneshr@...com>,
        <marcan@...can.st>, <sven@...npeter.dev>, <alyssa@...enzweig.io>,
        <kbusch@...nel.org>, <hch@....de>, <sagi@...mberg.me>,
        <sth@...ux.ibm.com>, <hoeppner@...ux.ibm.com>, <hca@...ux.ibm.com>,
        <gor@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
        <borntraeger@...ux.ibm.com>, <svens@...ux.ibm.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
        <kch@...dia.com>, <bhelgaas@...gle.com>, <john.garry@...wei.com>,
        <mcgrof@...nel.org>, <christophe.jaillet@...adoo.fr>,
        <vaibhavgupta40@...il.com>, <wsa+renesas@...g-engineering.com>,
        <damien.lemoal@...nsource.wdc.com>, <johannes.thumshirn@....com>,
        <bvanassche@....org>, <ming.lei@...hat.com>,
        <shinichiro.kawasaki@....com>, <vincent.fu@...sung.com>,
        <christoph.boehmwalder@...bit.com>, <joel@....id.au>,
        <vincent.whitchurch@...s.com>, <nbd@...er.debian.org>,
        <ceph-devel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        <asahi@...ts.linux.dev>
Subject: [RFC PATCH 02/21] loop: use lib tagset init helper

Use the block layer helper to initialize the common fields of tag_set
such as blk_mq_ops, number of h/w queues, queue depth, command size,
numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
is spread all over the block drivers. This avoids the code repetation of
the inialization code of the tag set in current block drivers and any
future ones.

Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
---
 drivers/block/loop.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ad92192c7d61..a915f25b4410 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1937,6 +1937,8 @@ static const struct blk_mq_ops loop_mq_ops = {
 
 static int loop_add(int i)
 {
+	unsigned int flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_STACKING |
+		BLK_MQ_F_NO_SCHED_BY_DEFAULT;
 	struct loop_device *lo;
 	struct gendisk *disk;
 	int err;
@@ -1967,14 +1969,8 @@ static int loop_add(int i)
 		goto out_free_dev;
 	i = err;
 
-	lo->tag_set.ops = &loop_mq_ops;
-	lo->tag_set.nr_hw_queues = 1;
-	lo->tag_set.queue_depth = hw_queue_depth;
-	lo->tag_set.numa_node = NUMA_NO_NODE;
-	lo->tag_set.cmd_size = sizeof(struct loop_cmd);
-	lo->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_STACKING |
-		BLK_MQ_F_NO_SCHED_BY_DEFAULT;
-	lo->tag_set.driver_data = lo;
+	blk_mq_init_tag_set(&lo->tag_set, &loop_mq_ops, 1, hw_queue_depth,
+			sizeof(struct loop_cmd), NUMA_NO_NODE, 0, flags, lo);
 
 	err = blk_mq_alloc_tag_set(&lo->tag_set);
 	if (err)
-- 
2.29.0