linux-kernel - [RFC PATCH 06/21] rnbd-clt: use lib tagset init helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 20:22:42 -0700
From:   Chaitanya Kulkarni <kch@...dia.com>
To:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>
CC:     <axboe@...nel.dk>, <efremov@...ux.com>, <josef@...icpanda.com>,
        <idryomov@...il.com>, <dongsheng.yang@...ystack.cn>,
        <haris.iqbal@...os.com>, <jinpu.wang@...os.com>, <mst@...hat.com>,
        <jasowang@...hat.com>, <pbonzini@...hat.com>,
        <stefanha@...hat.com>, <ohad@...ery.com>, <andersson@...nel.org>,
        <baolin.wang@...ux.alibaba.com>, <ulf.hansson@...aro.org>,
        <richard@....at>, <miquel.raynal@...tlin.com>, <vigneshr@...com>,
        <marcan@...can.st>, <sven@...npeter.dev>, <alyssa@...enzweig.io>,
        <kbusch@...nel.org>, <hch@....de>, <sagi@...mberg.me>,
        <sth@...ux.ibm.com>, <hoeppner@...ux.ibm.com>, <hca@...ux.ibm.com>,
        <gor@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
        <borntraeger@...ux.ibm.com>, <svens@...ux.ibm.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
        <kch@...dia.com>, <bhelgaas@...gle.com>, <john.garry@...wei.com>,
        <mcgrof@...nel.org>, <christophe.jaillet@...adoo.fr>,
        <vaibhavgupta40@...il.com>, <wsa+renesas@...g-engineering.com>,
        <damien.lemoal@...nsource.wdc.com>, <johannes.thumshirn@....com>,
        <bvanassche@....org>, <ming.lei@...hat.com>,
        <shinichiro.kawasaki@....com>, <vincent.fu@...sung.com>,
        <christoph.boehmwalder@...bit.com>, <joel@....id.au>,
        <vincent.whitchurch@...s.com>, <nbd@...er.debian.org>,
        <ceph-devel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        <asahi@...ts.linux.dev>
Subject: [RFC PATCH 06/21] rnbd-clt: use lib tagset init helper

Use the block layer helper to initialize the common fields of tag_set
such as blk_mq_ops, number of h/w queues, queue depth, command size,
numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
is spread all over the block drivers. This avoids the code repetation of
the inialization code of the tag set in current block drivers and any
future ones.

Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
---
 drivers/block/rnbd/rnbd-clt.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index 78334da74d8b..8f67a7e5299a 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1203,25 +1203,22 @@ static struct blk_mq_ops rnbd_mq_ops = {
 
 static int setup_mq_tags(struct rnbd_clt_session *sess)
 {
-	struct blk_mq_tag_set *tag_set = &sess->tag_set;
-
-	memset(tag_set, 0, sizeof(*tag_set));
-	tag_set->ops		= &rnbd_mq_ops;
-	tag_set->queue_depth	= sess->queue_depth;
-	tag_set->numa_node		= NUMA_NO_NODE;
-	tag_set->flags		= BLK_MQ_F_SHOULD_MERGE |
-				  BLK_MQ_F_TAG_QUEUE_SHARED;
-	tag_set->cmd_size	= sizeof(struct rnbd_iu) + RNBD_RDMA_SGL_SIZE;
-
-	/* for HCTX_TYPE_DEFAULT, HCTX_TYPE_READ, HCTX_TYPE_POLL */
-	tag_set->nr_maps        = sess->nr_poll_queues ? HCTX_MAX_TYPES : 2;
 	/*
 	 * HCTX_TYPE_DEFAULT and HCTX_TYPE_READ share one set of queues
 	 * others are for HCTX_TYPE_POLL
 	 */
-	tag_set->nr_hw_queues	= num_online_cpus() + sess->nr_poll_queues;
-	tag_set->driver_data    = sess;
+	unsigned int nr_hw_queue = num_online_cpus() + sess->nr_poll_queues;
+	struct blk_mq_tag_set *tag_set = &sess->tag_set;
 
+	memset(tag_set, 0, sizeof(*tag_set));
+	blk_mq_init_tag_set(tag_set, &rnbd_mq_ops, nr_hw_queue,
+			sess->queue_depth,
+			sizeof(struct rnbd_iu) + RNBD_RDMA_SGL_SIZE,
+			NUMA_NO_NODE, 0,
+			BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_TAG_QUEUE_SHARED, sess);
+	/* for HCTX_TYPE_DEFAULT, HCTX_TYPE_READ, HCTX_TYPE_POLL */
+
+	tag_set->nr_maps        = sess->nr_poll_queues ? HCTX_MAX_TYPES : 2;
 	return blk_mq_alloc_tag_set(tag_set);
 }
 
-- 
2.29.0