[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221005032257.80681-11-kch@nvidia.com>
Date: Tue, 4 Oct 2022 20:22:46 -0700
From: Chaitanya Kulkarni <kch@...dia.com>
To: <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-omap@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
<linux-mmc@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
<linux-scsi@...r.kernel.org>
CC: <axboe@...nel.dk>, <efremov@...ux.com>, <josef@...icpanda.com>,
<idryomov@...il.com>, <dongsheng.yang@...ystack.cn>,
<haris.iqbal@...os.com>, <jinpu.wang@...os.com>, <mst@...hat.com>,
<jasowang@...hat.com>, <pbonzini@...hat.com>,
<stefanha@...hat.com>, <ohad@...ery.com>, <andersson@...nel.org>,
<baolin.wang@...ux.alibaba.com>, <ulf.hansson@...aro.org>,
<richard@....at>, <miquel.raynal@...tlin.com>, <vigneshr@...com>,
<marcan@...can.st>, <sven@...npeter.dev>, <alyssa@...enzweig.io>,
<kbusch@...nel.org>, <hch@....de>, <sagi@...mberg.me>,
<sth@...ux.ibm.com>, <hoeppner@...ux.ibm.com>, <hca@...ux.ibm.com>,
<gor@...ux.ibm.com>, <agordeev@...ux.ibm.com>,
<borntraeger@...ux.ibm.com>, <svens@...ux.ibm.com>,
<jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
<kch@...dia.com>, <bhelgaas@...gle.com>, <john.garry@...wei.com>,
<mcgrof@...nel.org>, <christophe.jaillet@...adoo.fr>,
<vaibhavgupta40@...il.com>, <wsa+renesas@...g-engineering.com>,
<damien.lemoal@...nsource.wdc.com>, <johannes.thumshirn@....com>,
<bvanassche@....org>, <ming.lei@...hat.com>,
<shinichiro.kawasaki@....com>, <vincent.fu@...sung.com>,
<christoph.boehmwalder@...bit.com>, <joel@....id.au>,
<vincent.whitchurch@...s.com>, <nbd@...er.debian.org>,
<ceph-devel@...r.kernel.org>,
<virtualization@...ts.linux-foundation.org>,
<asahi@...ts.linux.dev>
Subject: [RFC PATCH 10/21] amiflop: use lib tagset init helper
Use the block layer helper to initialize the common fields of tag_set
such as blk_mq_ops, number of h/w queues, queue depth, command size,
numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
is spread all over the block drivers. This avoids the code repetation of
the inialization code of the tag set in current block drivers and any
future ones.
Signed-off-by: Chaitanya Kulkarni <kch@...dia.com>
---
drivers/block/amiflop.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 4c8b2ba579ee..af3f9a4b46ab 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1813,12 +1813,10 @@ static int fd_alloc_drive(int drive)
goto out;
memset(&unit[drive].tag_set, 0, sizeof(unit[drive].tag_set));
- unit[drive].tag_set.ops = &amiflop_mq_ops;
- unit[drive].tag_set.nr_hw_queues = 1;
+ blk_mq_init_tag_set(&unit[drive].tag_set, &amiflop_mq_ops, 1, 2, 0,
+ NUMA_NO_NODE, 0, BLK_MQ_F_SHOULD_MERGE, NULL);
unit[drive].tag_set.nr_maps = 1;
- unit[drive].tag_set.queue_depth = 2;
- unit[drive].tag_set.numa_node = NUMA_NO_NODE;
- unit[drive].tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
+
if (blk_mq_alloc_tag_set(&unit[drive].tag_set))
goto out_cleanup_trackbuf;
--
2.29.0
Powered by blists - more mailing lists