linux-kernel - Re: [PATCH] include/uapi/linux/swab: Fix potentially missing __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed9b8268-0128-0486-04a3-54f343afd38b@gmail.com>
Date:   Thu, 6 Oct 2022 13:33:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Nathan Chancellor <nathan@...nel.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org,
        Petr Vaněk <arkamar@...as.cz>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, Justin Stitt <jstitt007@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        "open list:CLANG/LLVM BUILD SUPPORT" <llvm@...ts.linux.dev>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-perf-users@...r.kernel.org>, mmayer@...adcom.com,
        Khem Raj <raj.khem@...il.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] include/uapi/linux/swab: Fix potentially missing
 __always_inline

Hi Nathan,

On 9/28/2022 3:36 PM, Nathan Chancellor wrote:
> Hi Florian,
> 
> On Tue, Sep 27, 2022 at 02:52:56PM -0700, Florian Fainelli wrote:
>> From: Matt Redfearn <matt.redfearn@...s.com>
>>
>> Commit bc27fb68aaad ("include/uapi/linux/byteorder, swab: force inlining
>> of some byteswap operations") added __always_inline to swab functions
>> and commit 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to
>> userspace headers") added a definition of __always_inline for use in
>> exported headers when the kernel's compiler.h is not available.
>>
>> However, since swab.h does not include stddef.h, if the header soup does
>> not indirectly include it, the definition of __always_inline is missing,
>> resulting in a compilation failure, which was observed compiling the
>> perf tool using exported headers containing this commit:
>>
>> In file included from /usr/include/linux/byteorder/little_endian.h:12:0,
>>                   from /usr/include/asm/byteorder.h:14,
>>                   from tools/include/uapi/linux/perf_event.h:20,
>>                   from perf.h:8,
>>                   from builtin-bench.c:18:
>> /usr/include/linux/swab.h:160:8: error: unknown type name `__always_inline'
>>   static __always_inline __u16 __swab16p(const __u16 *p)
>>
>> Fix this by replacing the inclusion of linux/compiler.h with
>> linux/stddef.h to ensure that we pick up that definition if required,
>> without relying on it's indirect inclusion. compiler.h is then included
>> indirectly, via stddef.h.
>>
>> Fixes: 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to userspace headers")
>> Signed-off-by: Matt Redfearn <matt.redfearn@...s.com>
>> Reviewed-by: Petr Vaněk <arkamar@...as.cz>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> I took this through my kernel build matrix and did not see any new
> issues.
> 
> Tested-by: Nathan Chancellor <nathan@...nel.org>

Great thanks! Since this is really useful for kernel-headers in 
toolchains, it would be great to get this picked up. Arnd is this 
something that would go via your tree?
-- 
Florian