linux-kernel - Re: [PATCH RESEND v4 0/2] drivers: bus: Add Freescale i.MX8qxp pixel link MSI bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b19fcc887b8a6fbc4b7d68cf03aa6626dc2a6fcc.camel@nxp.com>
Date:   Thu, 06 Oct 2022 11:18:06 +0800
From:   Liu Ying <victor.liu@....com>
To:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, saravanak@...gle.com,
        gregkh@...uxfoundation.org, geert+renesas@...der.be,
        krzysztof.kozlowski@...aro.org, robh@...nel.org
Subject: Re: [PATCH RESEND v4 0/2] drivers: bus: Add Freescale i.MX8qxp
 pixel link MSI bus support

Hi,

On Mon, 2022-08-22 at 14:03 +0800, Liu Ying wrote:
> Hi,
> 
> This series aims to add Freescale i.MX8qxp pixel link MSI bus support
> by using the existing simple-pm-bus driver. A power domain and two
> input
> clocks need to be enabled before the MSI bus accesses it's child
> devices,
> which matches what a simple power-managed bus is(See simple-pm-
> bus.yaml).
> 
> Patch 1 enables/disables functional clock(s) as a bulk in the
> simple-pm-bus driver when the simple-pm-bus is being power managed,
> since the MSI bus takes the two input clocks as functional clocks.
> 
> Patch 2 adds dt-bindings for the MSI bus.
> 
> v3->v4:
> * Drop patch 1 in v3, because simple-bus/simple-mfd devices probed by
> the
>   simple-pm-bus driver should not be child nodes of simple-pm-bus at
> all,
>   as simple-bus/simple-mfd's child devices PM operations cannot be
> propagated
>   to simple-pm-bus. Those simple-bus/simple-mfd devices needs
> dedicated drivers.
> * Drop unnecessary 'bus == NULL' check from
> simple_pm_bus_runtime_{suspend,resume}.
>   for patch 1 in v4. (Geert)
> * Add Geert's R-b tag on patch 1 in v4.
> * Add child nodes in the example MSI bus node of the MSI bus dt-
> binding. (Krzysztof)
> * Resend v4 to imply this series is based on v6.0-rc1 so that there
> are not any
>   dependencies for the MSI bus dt-binding. (Rob)
> 
> v2->v3:
> * Add a pattern property to allow child nodes in the MSI bus dt-
> binding. (Rob)
> 
> v1->v2:
> Address Krzysztof's comments on patch 3:
> * Add a select to explicitly select the MSI bus dt-binding.
> * List 'simple-pm-bus' explicitly as one item of compatible strings.
> * Require compatible and reg properties.
> * Put reg property just after compatible property in example.
> 
> 
> Liu Ying (2):
>   drivers: bus: simple-pm-bus: Use clocks
>   dt-bindings: bus: Add Freescale i.MX8qxp pixel link MSI bus binding
> 
>  .../bus/fsl,imx8qxp-pixel-link-msi-bus.yaml   | 232
> ++++++++++++++++++
>  drivers/bus/simple-pm-bus.c                   |  48 ++++
>  2 files changed, 280 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-
> bus.yaml
> 

I don't see any more comments on this patch series.  Can it be picked
up please?

Regards,
Liu Ying